Use ReadOnlyList instead of List

Author: linkdotnet

src/LinkDotNet.Blog.Infrastructure/PagedList.cs

@@ -9,7 +9,7 @@ public class PagedList<T> : IPagedList<T>
 {
     public static readonly PagedList<T> Empty = new(Enumerable.Empty<T>(), 0, 0, 0);
 
-    private readonly IList<T> subset;
+    private readonly IReadOnlyList<T> subset;
     private readonly int totalPages;
 
     public PagedList(IEnumerable<T> items, int pageNumber, int pageSize)
@@ -21,7 +21,7 @@ public PagedList(IEnumerable<T> items, int count, int pageNumber, int pageSize)
     {
         PageNumber = pageNumber;
         totalPages = (int)Math.Ceiling(count / (double)pageSize);
-        subset = items as IList<T> ?? new List<T>(items);
+        subset = items as IReadOnlyList<T> ?? items.ToArray();
     }
 
     public int PageNumber { get; }

src/LinkDotNet.Blog.Infrastructure/Persistence/InMemory/PaginatedListQueryExtensions.cs

@@ -14,7 +14,7 @@ public static Task<IPagedList<T>> ToPagedList<T>(this IEnumerable<T> source, int
             var items = source
                 .Skip((pageIndex - 1) * pageSize)
                 .Take(pageSize)
-                .ToList();
+                .ToArray();
             return Task.FromResult<IPagedList<T>>(new PagedList<T>(items, count, pageIndex, pageSize));
         }
 

src/LinkDotNet.Blog.Infrastructure/Persistence/RavenDb/PaginatedListQueryExtensions.cs

@@ -15,7 +15,7 @@ public static async Task<IPagedList<T>> ToPagedListAsync<T>(this IRavenQueryable
             var items = await source
                 .Skip((pageIndex - 1) * pageSize)
                 .Take(pageSize)
-                .ToListAsync(token);
+                .ToArrayAsync(token);
             return new PagedList<T>(items, count, pageIndex, pageSize);
         }
 

src/LinkDotNet.Blog.Infrastructure/Persistence/Sql/PaginatedListQueryExtensions.cs

@@ -18,7 +18,7 @@ public static async Task<IPagedList<T>> ToPagedListAsync<T>(this IQueryable<T> s
             var items = source
                 .Skip((page - 1) * pageSize)
                 .Take(pageSize)
-                .ToList();
+                .ToArray();
             return new PagedList<T>(items, count, page, pageSize);
         }