Adapt ValueTask in Repository

Author: linkdotnet

LinkDotNet.Blog.Infrastructure/Persistence/CachedRepository.cs

@@ -28,7 +28,7 @@ public CachedRepository(IRepository<T> repository, IMemoryCache memoryCache)
         AbsoluteExpirationRelativeToNow = TimeSpan.FromDays(7),
     };
 
-    public async Task<T> GetByIdAsync(string id)
+    public async ValueTask<T> GetByIdAsync(string id)
     {
         if (!memoryCache.TryGetValue(id, out T value))
         {
@@ -39,7 +39,7 @@ public async Task<T> GetByIdAsync(string id)
         return value;
     }
 
-    public async Task<IPagedList<T>> GetAllAsync(
+    public async ValueTask<IPagedList<T>> GetAllAsync(
         Expression<Func<T, bool>> filter = null,
         Expression<Func<T, object>> orderBy = null,
         bool descending = true,
@@ -54,14 +54,14 @@ public async Task<IPagedList<T>> GetAllAsync(
         });
     }
 
-    public async Task StoreAsync(T entity)
+    public async ValueTask StoreAsync(T entity)
     {
         await repository.StoreAsync(entity);
         ResetCache();
         memoryCache.Set(entity.Id, entity, Options);
     }
 
-    public async Task DeleteAsync(string id)
+    public async ValueTask DeleteAsync(string id)
     {
         ResetCache();
         memoryCache.Remove(id);

LinkDotNet.Blog.Infrastructure/Persistence/IRepository.cs

@@ -9,17 +9,17 @@ namespace LinkDotNet.Blog.Infrastructure.Persistence;
 public interface IRepository<TEntity>
 where TEntity : Entity
 {
-    Task<TEntity> GetByIdAsync(string id);
+    ValueTask<TEntity> GetByIdAsync(string id);
 
-    Task<IPagedList<TEntity>> GetAllAsync(
+    ValueTask<IPagedList<TEntity>> GetAllAsync(
         Expression<Func<TEntity, bool>> filter = null,
         Expression<Func<TEntity,
             object>> orderBy = null,
         bool descending = true,
         int page = 1,
         int pageSize = int.MaxValue);
 
-    Task StoreAsync(TEntity entity);
+    ValueTask StoreAsync(TEntity entity);
 
-    Task DeleteAsync(string id);
+    ValueTask DeleteAsync(string id);
 }

LinkDotNet.Blog.Infrastructure/Persistence/InMemory/Repository.cs

@@ -13,13 +13,13 @@ public class Repository<TEntity> : IRepository<TEntity>
 {
     private readonly List<TEntity> entities = new();
 
-    public Task<TEntity> GetByIdAsync(string id)
+    public ValueTask<TEntity> GetByIdAsync(string id)
     {
         var entity = entities.SingleOrDefault(b => b.Id == id);
-        return Task.FromResult(entity);
+        return new ValueTask<TEntity>(entity);
     }
 
-    public Task<IPagedList<TEntity>> GetAllAsync(
+    public ValueTask<IPagedList<TEntity>> GetAllAsync(
         Expression<Func<TEntity, bool>> filter = null,
         Expression<Func<TEntity, object>> orderBy = null,
         bool descending = true,
@@ -39,10 +39,10 @@ public Task<IPagedList<TEntity>> GetAllAsync(
                 : result.OrderBy(orderBy.Compile());
         }
 
-        return Task.FromResult(result.ToPagedList(page, pageSize));
+        return new ValueTask<IPagedList<TEntity>>(result.ToPagedList(page, pageSize));
     }
 
-    public Task StoreAsync(TEntity entity)
+    public ValueTask StoreAsync(TEntity entity)
     {
         if (string.IsNullOrEmpty(entity.Id))
         {
@@ -56,17 +56,17 @@ public Task StoreAsync(TEntity entity)
         }
 
         entities.Add(entity);
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
 
-    public Task DeleteAsync(string id)
+    public ValueTask DeleteAsync(string id)
     {
         var blogPostToDelete = entities.SingleOrDefault(b => b.Id == id);
         if (blogPostToDelete != null)
         {
             entities.Remove(blogPostToDelete);
         }
 
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
 }

LinkDotNet.Blog.Infrastructure/Persistence/RavenDb/Repository.cs

@@ -18,13 +18,13 @@ public Repository(IDocumentStore documentStore)
         this.documentStore = documentStore;
     }
 
-    public async Task<TEntity> GetByIdAsync(string id)
+    public async ValueTask<TEntity> GetByIdAsync(string id)
     {
         using var session = documentStore.OpenAsyncSession();
         return await session.LoadAsync<TEntity>(id);
     }
 
-    public async Task<IPagedList<TEntity>> GetAllAsync(
+    public async ValueTask<IPagedList<TEntity>> GetAllAsync(
         Expression<Func<TEntity, bool>> filter = null,
         Expression<Func<TEntity, object>> orderBy = null,
         bool descending = true,
@@ -49,14 +49,14 @@ public async Task<IPagedList<TEntity>> GetAllAsync(
         return await query.ToPagedListAsync(page, pageSize);
     }
 
-    public async Task StoreAsync(TEntity entity)
+    public async ValueTask StoreAsync(TEntity entity)
     {
         using var session = documentStore.OpenAsyncSession();
         await session.StoreAsync(entity);
         await session.SaveChangesAsync();
     }
 
-    public async Task DeleteAsync(string id)
+    public async ValueTask DeleteAsync(string id)
     {
         using var session = documentStore.OpenAsyncSession();
         session.Delete(id);

LinkDotNet.Blog.Infrastructure/Persistence/Sql/Repository.cs

@@ -18,12 +18,12 @@ public Repository(BlogDbContext blogDbContext)
         this.blogDbContext = blogDbContext;
     }
 
-    public async Task<TEntity> GetByIdAsync(string id)
+    public async ValueTask<TEntity> GetByIdAsync(string id)
     {
         return await blogDbContext.Set<TEntity>().SingleOrDefaultAsync(b => b.Id == id);
     }
 
-    public async Task<IPagedList<TEntity>> GetAllAsync(
+    public async ValueTask<IPagedList<TEntity>> GetAllAsync(
         Expression<Func<TEntity, bool>> filter = null,
         Expression<Func<TEntity, object>> orderBy = null,
         bool descending = true,
@@ -47,7 +47,7 @@ public async Task<IPagedList<TEntity>> GetAllAsync(
         return await entity.ToPagedListAsync(page, pageSize);
     }
 
-    public async Task StoreAsync(TEntity entity)
+    public async ValueTask StoreAsync(TEntity entity)
     {
         if (string.IsNullOrEmpty(entity.Id))
         {
@@ -61,7 +61,7 @@ public async Task StoreAsync(TEntity entity)
         await blogDbContext.SaveChangesAsync();
     }
 
-    public async Task DeleteAsync(string id)
+    public async ValueTask DeleteAsync(string id)
     {
         var entityToDelete = await GetByIdAsync(id);
         if (entityToDelete != null)