Removed unnecessary ToList calls

Author: linkdotnet

src/LinkDotNet.Blog.Web/Features/AboutMe/Components/Profile.razor

@@ -13,7 +13,7 @@
         <span>@AppConfiguration.ProfileInformation.Heading</span>
     </div>
     <div class="profile-image">
-        <img src="@AppConfiguration.ProfileInformation.ProfilePictureUrl" alt="Profile Picture" /> 
+        <img src="@AppConfiguration.ProfileInformation.ProfilePictureUrl" alt="Profile Picture" />
     </div>
     <ul class="profile-keypoints inverted-colors"
         ondragover="event.preventDefault();">
@@ -59,7 +59,7 @@ OnYesPressed="DeleteItem"></ConfirmDialog>
 
     protected override async Task OnInitializedAsync()
     {
-        profileInformationEntries = (await Repository.GetAllAsync()).OrderBy(d => d.SortOrder).ToList();
+        profileInformationEntries = (await Repository.GetAllAsync(orderBy: d => d.SortOrder, descending: false)).ToList();
     }
 
     private void ShowDeleteDialog(string key)

src/LinkDotNet.Blog.Web/Features/Admin/DraftBlogPost/DraftBlogPostPage.razor

@@ -14,11 +14,11 @@
 </div>
 
 @code {
-    private IList<BlogPost> blogPosts = new List<BlogPost>();
+    private IReadOnlyList<BlogPost> blogPosts = new List<BlogPost>();
 
     protected override async Task OnInitializedAsync()
     {
-        blogPosts = (await BlogPostRepository.GetAllAsync(p => !p.IsPublished, b => b.UpdatedDate)).ToList();
+        blogPosts = await BlogPostRepository.GetAllAsync(p => !p.IsPublished, b => b.UpdatedDate);
     }
 
 }

src/LinkDotNet.Blog.Web/Features/Admin/Sitemap/Services/SitemapService.cs

@@ -28,7 +28,7 @@ public async Task<SitemapUrlSet> CreateSitemapAsync()
     {
         var urlSet = new SitemapUrlSet();
 
-        var blogPosts = (await repository.GetAllAsync(f => f.IsPublished, b => b.UpdatedDate)).ToList();
+        var blogPosts = await repository.GetAllAsync(f => f.IsPublished, b => b.UpdatedDate);
 
         urlSet.Urls.Add(new SitemapUrl { Location = navigationManager.BaseUri });
         urlSet.Urls.Add(new SitemapUrl { Location = $"{navigationManager.BaseUri}archive" });

src/LinkDotNet.Blog.Web/Features/Search/SearchPage.razor

@@ -17,14 +17,14 @@
     [Parameter]
     public string SearchTerm { get; set; }
 
-    private IList<BlogPost> blogPosts = new List<BlogPost>();
+    private IReadOnlyList<BlogPost> blogPosts = new List<BlogPost>();
 
     protected override async Task OnParametersSetAsync()
     {
         var term = Uri.UnescapeDataString(SearchTerm);
-        blogPosts = (await BlogPostRepository.GetAllAsync(t => t.IsPublished && (t.Title.Contains(term)
-            || t.Tags.Any(tag => tag.Content == term)),
-            b => b.UpdatedDate)).ToList();
+        blogPosts = await BlogPostRepository.GetAllAsync(t => t.IsPublished && (t.Title.Contains(term)
+                                                                                 || t.Tags.Any(tag => tag.Content == term)),
+            b => b.UpdatedDate);
     }
 
     protected override async Task OnAfterRenderAsync(bool firstRender)

tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/RavenDb/BlogPostRepositoryTests.cs

@@ -106,7 +106,7 @@ public async Task ShouldGetAllBlogPosts()
         var blogPost = BlogPost.Create("Title", "Subtitle", "Content", "url", true, tags: new[] { "Tag 1", "Tag 2" });
         await SaveBlogPostAsync(blogPost);
 
-        var blogPostsFromRepo = (await sut.GetAllAsync()).ToList();
+        var blogPostsFromRepo = await sut.GetAllAsync();
 
         blogPostsFromRepo.Should().NotBeNull();
         blogPostsFromRepo.Should().HaveCount(1);

tests/LinkDotNet.Blog.IntegrationTests/Infrastructure/Persistence/Sql/BlogPostRepositoryTests.cs

@@ -54,7 +54,7 @@ public async Task ShouldGetAllBlogPosts()
         await DbContext.BlogPosts.AddAsync(blogPost);
         await DbContext.SaveChangesAsync();
 
-        var blogPostsFromRepo = (await Repository.GetAllAsync()).ToList();
+        var blogPostsFromRepo = await Repository.GetAllAsync();
 
         blogPostsFromRepo.Should().NotBeNull();
         blogPostsFromRepo.Should().HaveCount(1);

tests/LinkDotNet.Blog.IntegrationTests/Web/Shared/Skills/SkillTableTests.cs

@@ -25,7 +25,7 @@ public async Task ShouldDeleteItem()
 
         cut.FindComponent<SkillTag>().Find("button").Click();
 
-        var items = (await Repository.GetAllAsync()).ToList();
+        var items = await Repository.GetAllAsync();
         items.Should().HaveCount(0);
         cut.FindAll("td").Any(s => s.TextContent == "C#").Should().BeFalse();
     }