Fix tests

Author: linkdotnet

LinkDotNet.Blog.IntegrationTests/Web/Shared/ProfileTests.cs

@@ -19,7 +19,7 @@ public void ShouldRenderAllItemsSortedByOrder()
         {
             var entry1 = new ProfileInformationEntryBuilder().WithContent("key 1").WithSortOrder(1).Build();
             var entry2 = new ProfileInformationEntryBuilder().WithContent("key 2").WithSortOrder(2).Build();
-            var repoMock = RegisterServices();
+            var (repoMock, _) = RegisterServices();
             repoMock.Setup(r => r.GetAllAsync())
                 .ReturnsAsync(new List<ProfileInformationEntry> { entry1, entry2 });
             var cut = RenderComponent<Profile>();
@@ -49,7 +49,7 @@ public void ShouldShowAdminActionsWhenLoggedIn()
         [Fact]
         public void ShouldAddEntry()
         {
-            var repo = RegisterServices();
+            var (repo, _) = RegisterServices();
             ProfileInformationEntry entryToDb = null;
             repo.Setup(p => p.StoreAsync(It.IsAny<ProfileInformationEntry>()))
                 .Callback<ProfileInformationEntry>(p => entryToDb = p);
@@ -69,7 +69,7 @@ public void ShouldDeleteEntryWhenConfirmed()
         {
             var entryToDelete = new ProfileInformationEntryBuilder().WithContent("key 2").Build();
             entryToDelete.Id = "SomeId";
-            var repoMock = RegisterServices();
+            var (repoMock, _) = RegisterServices();
             repoMock.Setup(r => r.GetAllAsync()).ReturnsAsync(new[] { entryToDelete });
             var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
             cut.Find(".profile-keypoints li button").Click();
@@ -84,7 +84,7 @@ public void ShouldNotDeleteEntryWhenNotConfirmed()
         {
             var entryToDelete = new ProfileInformationEntryBuilder().WithContent("key 2").Build();
             entryToDelete.Id = "SomeId";
-            var repoMock = RegisterServices();
+            var (repoMock, _) = RegisterServices();
             repoMock.Setup(r => r.GetAllAsync()).ReturnsAsync(new[] { entryToDelete });
             var cut = RenderComponent<Profile>(p => p.Add(s => s.IsAuthenticated, true));
             cut.Find(".profile-keypoints li button").Click();
@@ -97,7 +97,7 @@ public void ShouldNotDeleteEntryWhenNotConfirmed()
         [Fact]
         public void ShouldAddEntryWithCorrectSortOrder()
         {
-            var repo = RegisterServices();
+            var (repo, _) = RegisterServices();
             var entry = new ProfileInformationEntryBuilder().WithSortOrder(1).Build();
             repo.Setup(p => p.GetAllAsync()).ReturnsAsync(new[] { entry });
             ProfileInformationEntry entryToDb = null;
@@ -114,6 +114,12 @@ public void ShouldAddEntryWithCorrectSortOrder()
             entryToDb.SortOrder.Should().Be(1001);
         }
 
+        [Fact]
+        public void ShouldSetNewOrderWhenItemDragAndDropped()
+        {
+
+        }
+
         private static AppConfiguration CreateEmptyConfiguration()
         {
             return new()
@@ -122,13 +128,15 @@ private static AppConfiguration CreateEmptyConfiguration()
             };
         }
 
-        private Mock<IProfileRepository> RegisterServices()
+        private (Mock<IProfileRepository> repoMock, Mock<ISortOrderCalculator> calcMock) RegisterServices()
         {
             var repoMock = new Mock<IProfileRepository>();
+            var calcMock = new Mock<ISortOrderCalculator>();
             Services.AddScoped(_ => CreateEmptyConfiguration());
             Services.AddScoped(_ => repoMock.Object);
+            Services.AddScoped(_ => calcMock.Object);
             repoMock.Setup(r => r.GetAllAsync()).ReturnsAsync(new List<ProfileInformationEntry>());
-            return repoMock;
+            return (repoMock, calcMock);
         }
     }
 }

LinkDotNet.Blog.UnitTests/Web/Shared/SortOrderCalculatorTests.cs

@@ -7,7 +7,7 @@ namespace LinkDotNet.Blog.UnitTests.Web.Shared
 {
     public class SortOrderCalculatorTests
     {
-        private SortOrderCalculator sut;
+        private readonly SortOrderCalculator sut;
 
         public SortOrderCalculatorTests()
         {

LinkDotNet.Blog.Web/Shared/Profile.razor

@@ -14,13 +14,14 @@
     <div class="profile-image">
         <img src="@appConfiguration.ProfileInformation.ProfilePictureUrl" alt="Profile Picture" /> 
     </div>
-    <ul class="profile-keypoints inverted-colors" ondragover="event.preventDefault();">
+    <ul class="profile-keypoints inverted-colors"
+        ondragover="event.preventDefault();">
         @foreach (var entry in profileInformationEntries)
         {
             @if (IsAuthenticated)
             {
                 <li
-                    style="cursor: move"
+                    class="item-draggable"
                     draggable="true"
                     @ondrag="@(() => currentDragItem = entry)"
                     @ondrop="@(() => HandleDrop(entry))">
@@ -54,6 +55,7 @@ OnYesPressed="DeleteItem"></ConfirmDialog>
     private ConfirmDialog Dialog { get; set; }
     private string currentDeleteKey;
     private ProfileInformationEntry currentDragItem;
+    private string dropClass = string.Empty;
 
     protected override async Task OnInitializedAsync()
     {
@@ -94,6 +96,7 @@ OnYesPressed="DeleteItem"></ConfirmDialog>
 
     private async Task HandleDrop(ProfileInformationEntry dropTarget)
     {
+        dropClass = string.Empty;
         if (currentDragItem == null || dropTarget  == currentDragItem)
         {
             return;
@@ -106,5 +109,4 @@ OnYesPressed="DeleteItem"></ConfirmDialog>
         profileInformationEntries.Sort((a, b) => a.SortOrder.CompareTo(b.SortOrder));
         StateHasChanged();
     }
-
 }

LinkDotNet.Blog.Web/Shared/Profile.razor.css

@@ -49,4 +49,8 @@
 /* As the MarkupComponent is a base class we have to use deep */
 ::deep .profile-keypoints li p {
     display: inline;
+}
+
+.item-draggable {
+    cursor: grab;
 }