Smaller refactoring in VisitCountPerPage

Author: linkdotnet

LinkDotNet.Blog.IntegrationTests/Web/Pages/Admin/Dashboard/VisitCountPerPageTests.cs

@@ -22,8 +22,7 @@ public async Task ShouldShowCounts()
             await Repository.StoreAsync(blogPost);
             using var ctx = new TestContext();
             ctx.Services.AddScoped<IRepository<BlogPost>>(_ => Repository);
-            var visits = new List<KeyValuePair<string, int>>();
-            visits.Add(new KeyValuePair<string, int>($"blogPost/{blogPost.Id}", 5));
+            var visits = new List<KeyValuePair<string, int>> { new($"blogPost/{blogPost.Id}", 5) };
             var pageVisitCounts = visits.OrderByDescending(s => s.Value);
 
             var cut = ctx.RenderComponent<VisitCountPerPage>(p => p.Add(
@@ -39,5 +38,33 @@ public async Task ShouldShowCounts()
             elements[1].InnerHtml.Should().Be("5");
             elements[2].InnerHtml.Should().Be("2");
         }
+
+        [Fact]
+        public void ShouldIgnoreNullForBlogPostVisits()
+        {
+            using var ctx = new TestContext();
+            ctx.Services.AddScoped<IRepository<BlogPost>>(_ => Repository);
+
+            var cut = ctx.RenderComponent<VisitCountPerPage>(p => p.Add(
+                s => s.PageVisitCount, null));
+
+            var elements = cut.FindAll("td").ToList();
+            elements.Should().BeEmpty();
+        }
+
+        [Fact]
+        public void ShouldIgnoreNotBlogPosts()
+        {
+            using var ctx = new TestContext();
+            ctx.Services.AddScoped<IRepository<BlogPost>>(_ => Repository);
+            var visits = new List<KeyValuePair<string, int>> { new("notablogpost", 5) };
+            var pageVisitCounts = visits.OrderByDescending(s => s.Value);
+
+            var cut = ctx.RenderComponent<VisitCountPerPage>(p => p.Add(
+                s => s.PageVisitCount, pageVisitCounts));
+
+            var elements = cut.FindAll("td").ToList();
+            elements.Should().BeEmpty();
+        }
     }
 }

LinkDotNet.Blog.Web/Shared/Admin/Dashboard/VisitCountPerPage.razor

@@ -43,14 +43,16 @@
 
         foreach (var (blogPostUrl, clickCount) in PageVisitCount)
         {
-            var blogPostId = blogPostUrl[(blogPostUrl.IndexOf('/') + 1)..];
+            const string urlToBlogPost = "blogPost/";
+            var possibleBlogPostId = blogPostUrl.IndexOf(urlToBlogPost, StringComparison.InvariantCultureIgnoreCase);
 
-            if (string.IsNullOrEmpty(blogPostId))
+            if (possibleBlogPostId == -1)
             {
                 continue;
             }
 
-            var blogPost = (await blogPostRepository.GetByIdAsync(blogPostId));
+            var blogPostId = blogPostUrl[urlToBlogPost.Length..];
+            var blogPost = await blogPostRepository.GetByIdAsync(blogPostId);
 
             blogPostToCountList.Add(new KeyValuePair<BlogPost, int>(blogPost, clickCount));
         }