Remove redundant config

Author: linkdotnet

LinkDotNet.Blog.UnitTests/Web/AppConfigurationFactoryTests.cs

@@ -22,7 +22,6 @@ public void ShouldMapFromAppConfiguration()
                 { "Introduction:ProfilePictureUrl", "anotherurl" },
                 { "Introduction:Description", "desc" },
                 { "BlogPostsPerPage", "5" },
-                { "IsAboutMeEnabled", "true" },
                 { "AboutMeProfileInformation:Name", "Steven" },
                 { "AboutMeProfileInformation:Heading", "Dev" },
                 { "AboutMeProfileInformation:ProfilePictureUrl", "Url" },
@@ -68,7 +67,6 @@ public void ShouldSetGithubLinkedAccountAccordingToValueSet(
                 { "GithubAccountUrl", githubUrl },
                 { "LinkedInAccountUrl", linkedInUrl },
                 { "BlogPostsPerPage", "2" },
-                { "IsAboutMeEnabled", "false" },
             };
             var configuration = new ConfigurationBuilder()
                 .AddInMemoryCollection(inMemorySettings)
@@ -79,5 +77,24 @@ public void ShouldSetGithubLinkedAccountAccordingToValueSet(
             appConfiguration.HasGithubAccount.Should().Be(githubAvailable);
             appConfiguration.HasLinkedinAccount.Should().Be(linkedInAvailable);
         }
+
+        [Fact]
+        public void ShouldSetIsAboutMeEnabledToFalseWhenNoInformation()
+        {
+            var inMemorySettings = new Dictionary<string, string>
+            {
+                { "Introduction:BackgroundUrl", "someurl" },
+                { "Introduction:ProfilePictureUrl", "anotherurl" },
+                { "Introduction:Description", "desc" },
+                { "BlogPostsPerPage", "2" },
+            };
+            var configuration = new ConfigurationBuilder()
+                .AddInMemoryCollection(inMemorySettings)
+                .Build();
+
+            var appConfiguration = AppConfigurationFactory.Create(configuration);
+
+            appConfiguration.IsAboutMeEnabled.Should().BeFalse();
+        }
     }
 }

LinkDotNet.Blog.Web/AppConfigurationFactory.cs

@@ -7,6 +7,7 @@ public static class AppConfigurationFactory
     {
         public static AppConfiguration Create(IConfiguration config)
         {
+            var profileInformation = config.GetSection("AboutMeProfileInformation").Get<ProfileInformation>();
             var configuration = new AppConfiguration
             {
                 BlogName = config["BlogName"],
@@ -16,15 +17,10 @@ public static AppConfiguration Create(IConfiguration config)
                 ConnectionString = config["ConnectionString"],
                 DatabaseName = config["DatabaseName"],
                 BlogPostsPerPage = int.Parse(config["BlogPostsPerPage"]),
-                IsAboutMeEnabled = bool.Parse(config["IsAboutMeEnabled"]),
+                ProfileInformation = profileInformation,
+                IsAboutMeEnabled = profileInformation != null,
             };
 
-            if (configuration.IsAboutMeEnabled)
-            {
-                configuration.ProfileInformation =
-                    config.GetSection("AboutMeProfileInformation").Get<ProfileInformation>();
-            }
-
             return configuration;
         }
     }

LinkDotNet.Blog.Web/appsettings.json

@@ -24,7 +24,6 @@
     "ClientSecret": ""
   },
   "BlogPostsPerPage": 10,
-  "IsAboutMeEnabled": true,  
   "AboutMeProfileInformation": {
     "Name": "Steven Giesel",
     "Heading": "Software Engineer",

Readme.md

@@ -39,7 +39,6 @@ The appsettings.json file has a lot of options to customize the content of the b
     "ClientSecret": ""
   },
   "BlogPostsPerPage": 10,
-  "IsAboutMeEnabled": true,
   "AboutMeProfileInformation": {
     "Name": "Steven Giesel",
     "Heading": "Software Engineer",
@@ -66,8 +65,7 @@ The appsettings.json file has a lot of options to customize the content of the b
 | ClientId                  | string         | See more details here: https://manage.auth0.com/dashboard/                                                                                                 |
 | ClientSecret              | string         | See more details here: https://manage.auth0.com/dashboard/                                                                                                 |
 | BlogPostsPerPage          | int            | Gives the amount of blog posts loaded and display per page. For more the user has to use the navigation                                                    |
-| IsAboutMeEnabled          | bool           | If true, enalbes the "About Me" page                                                                                                                       |
-| AboutMeProfileInformation | node           | If `IsAboutMeEnabled` is set to `false` this node can be left empty.                                                                                       |
+| AboutMeProfileInformation | node           | Sets information for the About Me Page. If omitted the page is disabled completely                                                                         |
 | Name                      | string         | Name, which is displayed on top of the profile card                                                                                                        |
 | Heading                   | string         | Displayed under the name. For example job title                                                                                                            |
 | ProfilePictureUrl         | string         | Displayed profile picture                                                                                                                                  |