Smaller improvements and added analyzer

Author: linkdotnet

CHANGELOG.md

@@ -9,6 +9,10 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 ### Addeed
 
 - Added overload which allows an initial string for the ValueStringBuilder
+- Meziantou.Analyzer as developer dependency to spot issues early on
+
+### Changed
+- Added `StructLayout(LayoutKind.Auto)`, which makes the ValueStringBuilder not usable for unmanaged code
 
 ## [1.5.1] - 2022-11-05
 

src/LinkDotNet.StringBuilder/LinkDotNet.StringBuilder.csproj

@@ -36,6 +36,10 @@
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>
+      <PackageReference Include="Meziantou.Analyzer" Version="1.0.746">
+        <PrivateAssets>all</PrivateAssets>
+        <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+      </PackageReference>
     </ItemGroup>
 
 </Project>

src/LinkDotNet.StringBuilder/TypedSpanList.cs

@@ -1,11 +1,13 @@
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 
 namespace LinkDotNet.StringBuilder;
 
 /// <summary>
 /// Represents a List based on the <see cref="Span{T}"/> type.
 /// </summary>
 /// <typeparam name="T">Any struct.</typeparam>
+[StructLayout(LayoutKind.Auto)]
 internal ref struct TypedSpanList<T>
     where T : struct
 {

src/LinkDotNet.StringBuilder/ValueStringBuilder.Replace.cs

@@ -114,7 +114,7 @@ public void Replace(scoped ReadOnlySpan<char> oldValue, scoped ReadOnlySpan<char
         var length = startIndex + count;
         var slice = buffer[startIndex..length];
 
-        if (oldValue == newValue)
+        if (oldValue.SequenceEqual(newValue))
         {
             return;
         }

tests/LinkDotNet.StringBuilder.UnitTests/LinkDotNet.StringBuilder.UnitTests.csproj

@@ -9,7 +9,7 @@
 
     <ItemGroup>
         <PackageReference Include="FluentAssertions" Version="6.8.0" />
-        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.3.2" />
+        <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
         <PackageReference Include="xunit" Version="2.4.2" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>