Better implementation for Append(bool) and new method

Author: linkdotnet

src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs

@@ -9,7 +9,22 @@ public ref partial struct ValueStringBuilder
     /// </summary>
     /// <param name="value">Bool value to add.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Append(bool value) => Append(value.ToString());
+    public void Append(bool value)
+    {
+        // 5 is the length of the string "False"
+        // So we can check if we have enough space in the buffer
+        if (bufferPosition + 5 > buffer.Length)
+        {
+            Grow(bufferPosition * 2);
+        }
+
+        if (!value.TryFormat(buffer[bufferPosition..], out var charsWritten))
+        {
+            throw new InvalidOperationException($"Could not add {value} to the builder.");
+        }
+
+        bufferPosition += charsWritten;
+    }
 
     /// <summary>
     /// Appends the string representation of the character to the builder.
@@ -60,6 +75,15 @@ public void AppendLine()
         Append(Environment.NewLine);
     }
 
+    /// <summary>
+    /// Appends a slice of memory.
+    /// </summary>
+    /// <param name="memory">The memory to add.</param>
+    public void Append(ReadOnlyMemory<char> memory)
+    {
+        Append(memory.Span);
+    }
+
     /// <summary>
     /// Does the same as <see cref="Append(char)"/> but adds a newline at the end.
     /// </summary>

tests/LinkDotNet.StringBuilder.Benchmarks/AppendFormatBenchmark.cs

@@ -5,25 +5,31 @@ namespace LinkDotNet.StringBuilder.Benchmarks;
 [MemoryDiagnoser]
 public class AppendFormatBenchmark
 {
-    [Benchmark(Baseline = true)]
-    public string DotNetStringBuilderAppendFormat()
+    [Benchmark]
+    public string ValueStringBuilderAppendFormat1()
     {
-        var builder = new System.Text.StringBuilder();
-        for (var i = 0; i < 10; i++)
+        using var builder = new ValueStringBuilder();
+        for (var i = 0; i < 100; i++)
         {
-            builder.AppendFormat("Hello {0} dear {1}. {2}", 2, "world", 30);
+            builder.Append(true);
+            builder.Append(false);
+            builder.Append(true);
+            builder.Append(false);
         }
 
         return builder.ToString();
     }
 
     [Benchmark]
-    public string ValueStringBuilderAppendFormat()
+    public string ValueStringBuilderAppendFormat2()
     {
         using var builder = new ValueStringBuilder();
-        for (var i = 0; i < 10; i++)
+        for (var i = 0; i < 100; i++)
         {
-            builder.AppendFormat("Hello {0} dear {1}. {2}", 2, "world", 30);
+            builder.Append(true);
+            builder.Append(false);
+            builder.Append(true);
+            builder.Append(false);
         }
 
         return builder.ToString();

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.Append.Tests.cs

@@ -155,4 +155,17 @@ public unsafe void ShouldAddCharPointer()
 
         builder.ToString().Should().Be("Hello");
     }
+
+    [Fact]
+    public void GivenMemorySlice_ShouldAppend()
+    {
+        using var builder = new ValueStringBuilder();
+        var memory = new Memory<char>(new char[100]);
+        var slice = memory[..5];
+        slice.Span.Fill('c');
+
+        builder.Append(slice);
+
+        builder.ToString().Should().Be("ccccc");
+    }
 }