Added the scoped keyword to simplify code

Author: linkdotnet

CHANGELOG.md

@@ -6,6 +6,9 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [Unreleased]
 
+### Added
+- Added the `scoped` keyword to simplify code and allow more scenarios for the user
+
 ## [1.3.0] - 2022-07-25
 
 ### Fixed

src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs

@@ -80,7 +80,7 @@ public ref partial struct ValueStringBuilder
     /// </summary>
     /// <param name="str">String, which will be added to this builder.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Append(ReadOnlySpan<char> str)
+    public void Append(scoped ReadOnlySpan<char> str)
     {
         var newSize = str.Length + bufferPosition;
         if (newSize > buffer.Length)
@@ -106,7 +106,7 @@ public void AppendLine()
     /// </summary>
     /// <param name="str">String, which will be added to this builder.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void AppendLine(ReadOnlySpan<char> str)
+    public void AppendLine(scoped ReadOnlySpan<char> str)
     {
         Append(str);
         Append(Environment.NewLine);

src/LinkDotNet.StringBuilder/ValueStringBuilder.Insert.cs

@@ -90,7 +90,7 @@ public ref partial struct ValueStringBuilder
     /// <param name="index">Index where <paramref name="value"/> should be inserted.</param>
     /// <param name="value">String to insert into this builder.</param>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Insert(int index, ReadOnlySpan<char> value)
+    public void Insert(int index, scoped ReadOnlySpan<char> value)
     {
         if (index < 0)
         {

src/LinkDotNet.StringBuilder/ValueStringBuilder.Replace.cs

@@ -1,5 +1,4 @@
-using System.Buffers;
-using System.Runtime.CompilerServices;
+using System.Runtime.CompilerServices;
 
 namespace LinkDotNet.StringBuilder;
 
@@ -86,14 +85,11 @@ public void ReplaceGeneric<T>(ReadOnlySpan<char> oldValue, T newValue, int start
     {
         if (newValue is ISpanFormattable spanFormattable)
         {
-            // Maybe we want to have a stackalloc here and more or less inline the whole function
-            var tempBuffer = ArrayPool<char>.Shared.Rent(24);
+            Span<char> tempBuffer = stackalloc char[24];
             if (spanFormattable.TryFormat(tempBuffer, out var written, default, null))
             {
-                Replace(oldValue, tempBuffer.AsSpan(0, written), startIndex, count);
+                Replace(oldValue, tempBuffer[..written], startIndex, count);
             }
-
-            ArrayPool<char>.Shared.Return(tempBuffer);
         }
         else
         {
@@ -113,7 +109,7 @@ public void ReplaceGeneric<T>(ReadOnlySpan<char> oldValue, T newValue, int start
     /// are removed from this builder.
     /// </remarks>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public void Replace(ReadOnlySpan<char> oldValue, ReadOnlySpan<char> newValue, int startIndex, int count)
+    public void Replace(scoped ReadOnlySpan<char> oldValue, scoped ReadOnlySpan<char> newValue, int startIndex, int count)
     {
         var length = startIndex + count;
         var slice = buffer[startIndex..length];