Updating to newest release

Author: LinkDotNet Bot

CHANGELOG.md

@@ -6,6 +6,13 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [Unreleased]
 
+## [1.18.6] - 2023-11-03
+
+### Changed
+
+-   `Dispose` resets the `ValueStringBuilder` to the initial state, so it doesn't lead to undefined behavior when used again
+-   Use different approach for `Grow` to be a bit more performant
+
 ## [1.18.5] - 2023-10-19
 
 ### Changed
@@ -374,7 +381,9 @@ This release brings extensions to the `ValueStringBuilder` API. For `v1.0` the `
 
 -   Initial release
 
-[Unreleased]: https://github.com/linkdotnet/StringBuilder/compare/1.18.5...HEAD
+[Unreleased]: https://github.com/linkdotnet/StringBuilder/compare/1.18.6...HEAD
+
+[1.18.6]: https://github.com/linkdotnet/StringBuilder/compare/1.18.5...1.18.6
 
 [1.18.5]: https://github.com/linkdotnet/StringBuilder/compare/1.18.4...1.18.5
 

src/LinkDotNet.StringBuilder/LinkDotNet.StringBuilder.csproj

@@ -40,7 +40,7 @@
 	</PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="Meziantou.Analyzer" Version="2.0.93">
+      <PackageReference Include="Meziantou.Analyzer" Version="2.0.103">
         <PrivateAssets>all</PrivateAssets>
         <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       </PackageReference>

src/LinkDotNet.StringBuilder/ValueStringBuilder.cs

@@ -286,12 +286,14 @@ public readonly int LastIndexOf(ReadOnlySpan<char> word, int startIndex)
     /// Disposes the instance and returns rented buffer from an array pool if needed.
     /// </summary>
     [MethodImpl(MethodImplOptions.AggressiveInlining)]
-    public readonly void Dispose()
+    public void Dispose()
     {
         if (arrayFromPool != null)
         {
             ArrayPool<char>.Shared.Return(arrayFromPool);
         }
+
+        this = default;
     }
 
     /// <summary>
@@ -311,7 +313,18 @@ private void Grow(int capacity = 0)
         }
 
         var rented = ArrayPool<char>.Shared.Rent(size);
-        buffer[..bufferPosition].CopyTo(rented);
+
+        if (bufferPosition > 0)
+        {
+            ref var sourceRef = ref MemoryMarshal.GetReference(buffer);
+            ref var destinationRef = ref MemoryMarshal.GetReference(rented.AsSpan());
+
+            Unsafe.CopyBlock(
+                ref Unsafe.As<char, byte>(ref destinationRef),
+                ref Unsafe.As<char, byte>(ref sourceRef),
+                (uint)(bufferPosition * sizeof(char)));
+        }
+
         var oldBufferFromPool = arrayFromPool;
         buffer = arrayFromPool = rented;
 

tests/LinkDotNet.StringBuilder.Benchmarks/AppendBenchmark.cs

@@ -5,17 +5,6 @@ namespace LinkDotNet.StringBuilder.Benchmarks;
 [MemoryDiagnoser]
 public class AppendBenchmarks
 {
-    [Benchmark(Baseline = true)]
-    public string DotNetStringBuilder()
-    {
-        var builder = new System.Text.StringBuilder();
-        builder.AppendLine("That is the first line of our benchmark.");
-        builder.AppendLine("We can multiple stuff in here if want.");
-        builder.AppendLine("The idea is that we can resize the internal structure from time to time.");
-        builder.AppendLine("We can also add other Append method if we want. But we keep it easy for now.");
-        return builder.ToString();
-    }
-
     [Benchmark]
     public string ValueStringBuilder()
     {
@@ -27,16 +16,4 @@ public string ValueStringBuilder()
         builder.AppendLine("We can also add other Append method if we want. But we keep it easy for now.");
         return builder.ToString();
     }
-
-    [Benchmark]
-    public string ValueStringBuilderPreAllocated()
-    {
-        using var builder = new ValueStringBuilder(stackalloc char[256]);
-        builder.AppendLine("That is the first line of our benchmark.");
-        builder.AppendLine("We can multiple stuff in here if want.");
-        builder.AppendLine("We can multiple stuff in here if want.");
-        builder.AppendLine("The idea is that we can resize the internal structure from time to time.");
-        builder.AppendLine("We can also add other Append method if we want. But we keep it easy for now.");
-        return builder.ToString();
-    }
 }

tests/LinkDotNet.StringBuilder.Benchmarks/LinkDotNet.StringBuilder.Benchmarks.csproj

@@ -9,7 +9,7 @@
     </PropertyGroup>
 
     <ItemGroup>
-      <PackageReference Include="BenchmarkDotNet" Version="0.13.9" />
+      <PackageReference Include="BenchmarkDotNet" Version="0.13.10" />
     </ItemGroup>
 
     <ItemGroup>

tests/LinkDotNet.StringBuilder.UnitTests/LinkDotNet.StringBuilder.UnitTests.csproj

@@ -10,7 +10,7 @@
     <ItemGroup>
         <PackageReference Include="FluentAssertions" Version="6.12.0" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
-        <PackageReference Include="xunit" Version="2.5.3" />
+        <PackageReference Include="xunit" Version="2.6.1" />
         <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilderTests.cs

@@ -503,4 +503,14 @@ public void GivenAString_WhenEnumerating_ThenShouldReturnCharacters()
 
         output.Should().Be("Hello World");
     }
+
+    [Fact]
+    public void GivenStringBuilder_WhenDisposed_ThenEmtpyStringReturned()
+    {
+        var builder = new ValueStringBuilder("Hello World");
+
+        builder.Dispose();
+
+        builder.ToString().Should().Be(string.Empty);
+    }
 }