Refactored Remove method

Author: linkdotnet

src/LinkDotNet.StringBuilder/ValueStringBuilder.cs

@@ -77,6 +77,11 @@ public void Clear()
     /// </remarks>
     public void Remove(int startIndex, int length)
     {
+        if (length == 0)
+        {
+            return;
+        }
+
         if (length < 0)
         {
             throw new ArgumentOutOfRangeException(nameof(length), "The given length can't be negative.");
@@ -89,12 +94,7 @@ public void Remove(int startIndex, int length)
 
         if (length > Length - startIndex)
         {
-            throw new ArgumentOutOfRangeException(nameof(length), "The given length is longer than the represented string.");
-        }
-
-        if (startIndex >= Length)
-        {
-            throw new ArgumentOutOfRangeException(nameof(startIndex), "The given startIndex is larger than the represented string.");
+            throw new ArgumentOutOfRangeException(nameof(length), $"The given Span ({startIndex}..{length})length is outside the the represented string.");
         }
 
         var beginIndex = startIndex + length;

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilderTests.cs

@@ -157,11 +157,10 @@ public void ShouldRemoveRange()
     [InlineData(-1, 2)]
     [InlineData(1, -2)]
     [InlineData(90, 1)]
-    [InlineData(1, 90)]
-    public void ShouldThrowExceptionWhenNegativeStartIndex(int startIndex, int length)
+    public void ShouldThrowExceptionWhenOutOfRangeIndex(int startIndex, int length)
     {
         var stringBuilder = new ValueStringBuilder();
-        stringBuilder.Append("Hello World");
+        stringBuilder.Append("Hello");
 
         try
         {
@@ -175,4 +174,15 @@ public void ShouldThrowExceptionWhenNegativeStartIndex(int startIndex, int lengt
 
         Assert.False(true);
     }
+
+    [Fact]
+    public void ShouldNotRemoveEntriesWhenLengthIsEqualToZero()
+    {
+        var stringBuilder = new ValueStringBuilder();
+        stringBuilder.Append("Hello");
+
+        stringBuilder.Remove(0, 0);
+
+        stringBuilder.ToString().Should().Be("Hello");
+    }
 }