Skip to content

Commit 84e9fed

Browse files
committed
Fixed tests and JIT hints
1 parent a580b61 commit 84e9fed

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/LinkDotNet.StringBuilder/ValueStringBuilder.Trim.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ public ref partial struct ValueStringBuilder
77
/// <summary>
88
/// Removes a set of whitespace characters from the beginning and ending of this string.
99
/// </summary>
10-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
10+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
1111
public void Trim()
1212
{
1313
// Hint: We don't want to call TrimStart and TrimEnd because we don't want to copy the buffer twice.
@@ -36,7 +36,7 @@ public void Trim()
3636
/// Removes the specified character from the beginning and end of this string.
3737
/// </summary>
3838
/// <param name="c">The character to remove.</param>
39-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
39+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
4040
public void Trim(char c)
4141
{
4242
// Remove character from the beginning
@@ -64,7 +64,7 @@ public void Trim(char c)
6464
/// <summary>
6565
/// Removes a set of whitespace characters from the beginning of this string.
6666
/// </summary>
67-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
67+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
6868
public void TrimStart()
6969
{
7070
var start = 0;
@@ -85,7 +85,7 @@ public void TrimStart()
8585
/// Removes the specified character from the beginning of this string.
8686
/// </summary>
8787
/// <param name="c">The character to remove.</param>
88-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
88+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
8989
public void TrimStart(char c)
9090
{
9191
var start = 0;
@@ -105,7 +105,7 @@ public void TrimStart(char c)
105105
/// <summary>
106106
/// Removes a set of whitespace characters from the ending of this string.
107107
/// </summary>
108-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
108+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
109109
public void TrimEnd()
110110
{
111111
var end = bufferPosition - 1;
@@ -121,7 +121,7 @@ public void TrimEnd()
121121
/// Removes the specified character from the end of this string.
122122
/// </summary>
123123
/// <param name="c">The character to remove.</param>
124-
[MethodImpl(MethodImplOptions.AggressiveInlining)]
124+
[MethodImpl(MethodImplOptions.AggressiveOptimization)]
125125
public void TrimEnd(char c)
126126
{
127127
var end = bufferPosition - 1;

tests/LinkDotNet.StringBuilder.Benchmarks/AppendFormatBenchmark.cs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ namespace LinkDotNet.StringBuilder.Benchmarks;
66
public class AppendFormatBenchmark
77
{
88
[Benchmark]
9-
public string ValueStringBuilderAppendFormat1()
9+
public string ValueStringBuilderAppendFormat()
1010
{
1111
using var builder = new ValueStringBuilder();
1212
for (var i = 0; i < 100; i++)
@@ -21,9 +21,9 @@ public string ValueStringBuilderAppendFormat1()
2121
}
2222

2323
[Benchmark]
24-
public string ValueStringBuilderAppendFormat2()
24+
public string StringBuilderAppendFormat()
2525
{
26-
using var builder = new ValueStringBuilder();
26+
var builder = new System.Text.StringBuilder();
2727
for (var i = 0; i < 100; i++)
2828
{
2929
builder.Append(true);

0 commit comments

Comments
 (0)