Remove redundant null check

Author: linkdotnet

CHANGELOG.md

@@ -8,6 +8,10 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 
 ## [1.8.0] - 2022-11-15
 
+### Changed
+
+- Slight improvement when appending nullable types to the string builder
+
 ### Added
 
 -   implicit cast operator from `string` and `ReadOnlySpan<char>` to the `ValueStringBuilder` with pre-initialized buffer

src/LinkDotNet.StringBuilder/ValueStringBuilder.AppendJoin.cs

@@ -64,10 +64,7 @@ private void AppendJoinInternalString<T2>(ReadOnlySpan<char> separator, IEnumera
         {
             Append(separator);
             current = enumerator.Current;
-            if (current != null)
-            {
-                AppendInternal(current);
-            }
+            AppendInternal(current);
         }
     }
 
@@ -93,10 +90,7 @@ private void AppendJoinInternalChar<T2>(char separator, IEnumerable<T2> values)
         {
             AppendInternal(separator);
             current = enumerator.Current;
-            if (current != null)
-            {
-                AppendInternal(current);
-            }
+            AppendInternal(current);
         }
     }
 

tests/LinkDotNet.StringBuilder.UnitTests/ValueStringBuilder.AppendJoin.Tests.cs

@@ -10,13 +10,15 @@ public static IEnumerable<object[]> StringSeparatorTestData()
         yield return new object[] { ",", new[] { "Hello", "World" }, "Hello,World" };
         yield return new object[] { ",", new[] { "Hello" }, "Hello" };
         yield return new object[] { ",", Array.Empty<string>(), string.Empty };
+        yield return new object[] { ",", new string?[] { null }, string.Empty };
     }
 
     public static IEnumerable<object[]> CharSeparatorTestData()
     {
         yield return new object[] { ',', new[] { "Hello", "World" }, "Hello,World" };
         yield return new object[] { ',', new[] { "Hello" }, "Hello" };
         yield return new object[] { ',', Array.Empty<string>(), string.Empty };
+        yield return new object[] { ',', new string?[] { null }, string.Empty };
     }
 
     [Theory]
@@ -46,18 +48,18 @@ public void ShouldAddDataWithStringSeparator()
     {
         using var stringBuilder = new ValueStringBuilder();
 
-        stringBuilder.AppendJoin(",", new object[] { 1, new DateTime(1900, 1, 1) });
+        stringBuilder.AppendJoin(",", new object[] { 1, 1.05f });
 
-        stringBuilder.ToString().Should().Be("1,01/01/1900 00:00:00");
+        stringBuilder.ToString().Should().Be("1,1.05");
     }
 
     [Fact]
     public void ShouldAddDataWithCharSeparator()
     {
         using var stringBuilder = new ValueStringBuilder();
 
-        stringBuilder.AppendJoin(',', new object[] { 1, new DateTime(1900, 1, 1) });
+        stringBuilder.AppendJoin(',', new object[] { 1, 1.05f });
 
-        stringBuilder.ToString().Should().Be("1,01/01/1900 00:00:00");
+        stringBuilder.ToString().Should().Be("1,1.05");
     }
 }