Skip to content

Commit c07e47c

Browse files
committed
Remove redundant null check
1 parent 69a1079 commit c07e47c

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,9 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
66

77
## [Unreleased]
88

9+
### Changed
10+
- Remove redundant null check when using `AppendJoin`
11+
912
## [1.12.0] - 2023-01-09
1013

1114
### Added

src/LinkDotNet.StringBuilder/ValueStringBuilder.AppendJoin.cs

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ public void AppendJoin<T>(char separator, IEnumerable<T> values)
4343
=> AppendJoinInternalChar(separator, values);
4444

4545
[MethodImpl(MethodImplOptions.AggressiveInlining)]
46-
private void AppendJoinInternalString<T2>(ReadOnlySpan<char> separator, IEnumerable<T2> values)
46+
private void AppendJoinInternalString<T>(ReadOnlySpan<char> separator, IEnumerable<T> values)
4747
{
4848
ArgumentNullException.ThrowIfNull(values);
4949

@@ -69,7 +69,7 @@ private void AppendJoinInternalString<T2>(ReadOnlySpan<char> separator, IEnumera
6969
}
7070

7171
[MethodImpl(MethodImplOptions.AggressiveInlining)]
72-
private void AppendJoinInternalChar<T2>(char separator, IEnumerable<T2> values)
72+
private void AppendJoinInternalChar<T>(char separator, IEnumerable<T> values)
7373
{
7474
ArgumentNullException.ThrowIfNull(values);
7575

@@ -81,10 +81,7 @@ private void AppendJoinInternalChar<T2>(char separator, IEnumerable<T2> values)
8181
}
8282

8383
var current = enumerator.Current;
84-
if (current != null)
85-
{
86-
AppendInternal(current);
87-
}
84+
AppendInternal(current);
8885

8986
while (enumerator.MoveNext())
9087
{

0 commit comments

Comments
 (0)