Removed AggressiveOptimiztation

Author: linkdotnet

CHANGELOG.md

@@ -7,7 +7,7 @@ All notable changes to **ValueStringBuilder** will be documented in this file. T
 ## [Unreleased]
 
 ### Added
- - Enabled more optimizations.
+ - Enabled some optimization hints for the compiler.
 
 ## [1.0.0] - 2022-04-12
 
@@ -64,4 +64,4 @@ This release brings extensions to the `ValueStringBuilder` API. For `v1.0` the `
 
 [1.0.0]: https://github.com/linkdotnet/StringBuilder/compare/0.9.5...1.0.0
 
-[0.9.5]: https://github.com/linkdotnet/StringBuilder/compare/0.9.4...0.9.5
+[0.9.5]: https://github.com/linkdotnet/StringBuilder/compare/0.9.4...0.9.5

src/LinkDotNet.StringBuilder/TypedSpanList.cs

@@ -24,7 +24,6 @@ public TypedSpanList()
 
     public ReadOnlySpan<T> AsSpan => buffer[..count];
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public void Add(T value)
     {
         if (count >= buffer.Length)

src/LinkDotNet.StringBuilder/ValueStringBuilder.Append.cs

@@ -69,7 +69,6 @@ public ref partial struct ValueStringBuilder
     /// Appends a string to the string builder.
     /// </summary>
     /// <param name="str">String, which will be added to this builder.</param>
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public void Append(ReadOnlySpan<char> str)
     {
         var newSize = str.Length + bufferPosition;
@@ -102,7 +101,6 @@ public void AppendLine(ReadOnlySpan<char> str)
         Append(Environment.NewLine);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     private void AppendSpanFormattable<T>(T value)
         where T : ISpanFormattable
     {

src/LinkDotNet.StringBuilder/ValueStringBuilder.AppendJoin.cs

@@ -42,7 +42,6 @@ public void AppendJoin<T>(ReadOnlySpan<char> separator, IEnumerable<T> values)
     public void AppendJoin<T>(char separator, IEnumerable<T> values)
         => AppendJoinInternalChar(separator, values);
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     private void AppendJoinInternalString<T2>(ReadOnlySpan<char> separator, IEnumerable<T2> values)
     {
         ArgumentNullException.ThrowIfNull(values);
@@ -71,7 +70,6 @@ private void AppendJoinInternalString<T2>(ReadOnlySpan<char> separator, IEnumera
         }
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     private void AppendJoinInternalChar<T2>(char separator, IEnumerable<T2> values)
     {
         ArgumentNullException.ThrowIfNull(values);
@@ -100,7 +98,6 @@ private void AppendJoinInternalChar<T2>(char separator, IEnumerable<T2> values)
         }
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     private void AppendInternal<T>(T value)
     {
         if (value is ISpanFormattable spanFormattable)

src/LinkDotNet.StringBuilder/ValueStringBuilder.cs

@@ -103,7 +103,6 @@ public void Clear()
     /// <remarks>
     /// If <paramref name="newCapacity"/> is smaller or equal to <see cref="Length"/> nothing will be done.
     /// </remarks>
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public void EnsureCapacity(int newCapacity)
     {
         if (newCapacity < 0)
@@ -125,7 +124,6 @@ public void EnsureCapacity(int newCapacity)
     /// <remarks>
     /// This method will not affect the internal size of the string.
     /// </remarks>
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public void Remove(int startIndex, int length)
     {
         if (length == 0)
@@ -167,7 +165,6 @@ public void Remove(int startIndex, int length)
     /// <param name="word">Word to look for in this string.</param>
     /// <param name="startIndex">Index to begin with.</param>
     /// <returns>The index of the found <paramref name="word"/> in this string or -1 if not found.</returns>
-    [MethodImpl(MethodImplOptions.AggressiveInlining)]
     public int IndexOf(ReadOnlySpan<char> word, int startIndex)
     {
         if (startIndex < 0)
@@ -192,7 +189,6 @@ public int IndexOf(ReadOnlySpan<char> word, int startIndex)
     /// <param name="word">Word to look for in this string.</param>
     /// <param name="startIndex">Index to begin with.</param>
     /// <returns>The index of the found <paramref name="word"/> in this string or -1 if not found.</returns>
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     public int LastIndexOf(ReadOnlySpan<char> word, int startIndex)
     {
         if (startIndex < 0)
@@ -203,7 +199,6 @@ public int LastIndexOf(ReadOnlySpan<char> word, int startIndex)
         return NaiveSearch.FindLast(buffer[startIndex..bufferPosition], word);
     }
 
-    [MethodImpl(MethodImplOptions.AggressiveOptimization)]
     private void Grow(int capacity = 0)
     {
         var currentSize = buffer.Length;