Update packages & migrate to Shouldly #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Oh amazing - I moved from Big thanks!!! |
linkdotnet
reviewed
Jan 23, 2025
linkdotnet
reviewed
Jan 23, 2025
tests/LinkDotNet.StringBuilder.Benchmarks/LinkDotNet.StringBuilder.Benchmarks.csproj
Outdated
Show resolved
Hide resolved
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates all the packages to their latest versions, but the second commit also replaces FluentAssertions with Shouldly.
If you didn't know, FluentAssertions v8 changed their license so that it's no longer open-source (previously Apache-2.0). The new license requires you pay $130 per seat for commercial use. So I migrated the tests in this library to Shouldly, a similar library under BSD-3-clause. I haven't used it before but it seems more consistent from what I can see.
Alternatively, you could continue using FluentAssertions v7 and pin it at
[7.0.0](or[7.1.0]). Up to you!