add http status suffix

HighKo · HighKo · commit 39febf70992a · 2024-03-17T10:52:38.000+01:00
error messages differ too much across clients
diff --git a/kotlin-jira-client/kotlin-jira-client-sdk/src/main/kotlin/com/linkedplanet/kotlinjiraclient/sdk/util/EitherExtension.kt b/kotlin-jira-client/kotlin-jira-client-sdk/src/main/kotlin/com/linkedplanet/kotlinjiraclient/sdk/util/EitherExtension.kt
@@ -60,10 +60,12 @@ fun <T> withErrorCollection(
 
 fun jiraClientError(errorCollection: ErrorCollection, errorTitle: String = "SdkError"): JiraClientError {
     val worstReason: ErrorCollection.Reason? = ErrorCollection.Reason.getWorstReason(errorCollection.reasons)
+    val httpStatusSuffix = worstReason?.let { " (Status Code ${it.httpStatusCode})" } ?: ""
     return JiraClientError(
         error = errorTitle,
         message = errorCollection.errorMessages.joinToString(", \n")
-                + errorCollection.errors.map { "'${it.key}': ${it.value}" }.joinToString(", \n"),
+                + errorCollection.errors.map { "'${it.key}': ${it.value}" }.joinToString(", \n")
+                + httpStatusSuffix,
         statusCode = worstReason?.httpStatusCode
     )
 }

Original file line number	Diff line number	Diff line change
`@@ -60,10 +60,12 @@ fun <T> withErrorCollection(`
`60`	`60`
`61`	`61`	`fun jiraClientError(errorCollection: ErrorCollection, errorTitle: String = "SdkError"): JiraClientError {`
`62`	`62`	`val worstReason: ErrorCollection.Reason? = ErrorCollection.Reason.getWorstReason(errorCollection.reasons)`
	`63`	`+ val httpStatusSuffix = worstReason?.let { " (Status Code ${it.httpStatusCode})" } ?: ""`
`63`	`64`	`return JiraClientError(`
`64`	`65`	`error = errorTitle,`
`65`	`66`	`message = errorCollection.errorMessages.joinToString(", \n")`
`66`		`- + errorCollection.errors.map { "'${it.key}': ${it.value}" }.joinToString(", \n"),`
	`67`	`+ + errorCollection.errors.map { "'${it.key}': ${it.value}" }.joinToString(", \n")`
	`68`	`+ + httpStatusSuffix,`
`67`	`69`	`statusCode = worstReason?.httpStatusCode`
`68`	`70`	`)`
`69`	`71`	`}`