Revert "add withChildren to getObjectTypesBySchema"

This reverts commit a924aa6.

Author: HighKo

kotlin-insight-client/kotlin-insight-client-api/src/main/kotlin/com/linkedplanet/kotlininsightclient/api/interfaces/InsightObjectTypeOperator.kt

@@ -45,10 +45,7 @@ interface InsightObjectTypeOperator {
      * @param schemaId The ID of the schema.
      * @return either an [InsightClientError] or a list of [ObjectTypeSchema] objects representing the object types in the schema.
      */
-    suspend fun getObjectTypesBySchema(
-        schemaId: InsightSchemaId,
-        withChildren: Boolean = true
-    ): Either<InsightClientError, List<ObjectTypeSchema>>
+    suspend fun getObjectTypesBySchema(schemaId: InsightSchemaId): Either<InsightClientError, List<ObjectTypeSchema>>
 
     /**
      * Retrieves a list of Insight object types that belong to the schema with the specified ID and have the specified root object type.

kotlin-insight-client/kotlin-insight-client-http/src/main/kotlin/com/linkedplanet/kotlininsightclient/http/HttpInsightObjectTypeOperator.kt

@@ -71,10 +71,7 @@ class HttpInsightObjectTypeOperator(private val context: HttpInsightClientContex
             ?: ObjectTypeNotFoundError(rootObjectTypeId).asEither<List<ObjectTypeSchema>>().bind()
     }
 
-    override suspend fun getObjectTypesBySchema(
-        schemaId: InsightSchemaId,
-        withChildren: Boolean
-    ): Either<InsightClientError, List<ObjectTypeSchema>> =
+    override suspend fun getObjectTypesBySchema(schemaId: InsightSchemaId): Either<InsightClientError, List<ObjectTypeSchema>> =
         either {
             context.httpClient.executeRestList<ObjectTypeSchemaApiResponse>(
                 "GET",

kotlin-insight-client/kotlin-insight-client-sdk/src/main/kotlin/com/linkedplanet/kotlininsightclient/sdk/SdkInsightObjectTypeOperator.kt

@@ -46,17 +46,9 @@ object SdkInsightObjectTypeOperator : InsightObjectTypeOperator {
             objectTypeSchemaForBean(objectTypeBean)
         }
 
-    override suspend fun getObjectTypesBySchema(
-        schemaId: InsightSchemaId,
-        withChildren: Boolean
-    ): Either<InsightClientError, List<ObjectTypeSchema>> =
+    override suspend fun getObjectTypesBySchema(schemaId: InsightSchemaId): Either<InsightClientError, List<ObjectTypeSchema>> =
         catchAsInsightClientError {
-            val objectTypeBeans: List<ObjectTypeBean> = if (withChildren) {
-                objectTypeFacade.findObjectTypeBeansFlat(schemaId.raw)
-            } else {
-                objectTypeFacade.findObjectTypeBeans(schemaId.raw)
-            }
-            objectTypeBeans
+            objectTypeFacade.findObjectTypeBeansFlat(schemaId.raw)
                 .map(::objectTypeSchemaForBean)
         }