Fixing java 17 LocalDate InaccessibleObjectException

Author: Philipp Karlsson

kotlin-insight-client/kotlin-insight-client-api/src/main/kotlin/com/linkedplanet/kotlininsightclient/api/impl/GsonUtil.kt

@@ -25,19 +25,42 @@ import com.google.gson.stream.JsonReader
 import com.google.gson.stream.JsonWriter
 import com.linkedplanet.kotlininsightclient.api.model.InsightAttribute
 import com.linkedplanet.kotlininsightclient.api.model.ObjectTypeSchemaAttribute
+import java.time.LocalDate
+import java.time.LocalTime
 import java.time.ZonedDateTime
 
 
 class GsonUtil {
     companion object {
         fun gsonBuilder(): GsonBuilder = GsonBuilder()
+            .registerTypeAdapter(LocalDate::class.java, localDateAdapter)
+            .registerTypeAdapter(LocalTime::class.java, localTimeAdapter)
             .registerTypeAdapter(ZonedDateTime::class.java, zonedDateTimeAdapter)
             .registerTypeAdapterFactory(SealedTypeAdapterFactory.of(InsightAttribute::class))
             .registerTypeAdapterFactory(SealedTypeAdapterFactory.of(ObjectTypeSchemaAttribute::class,
                 typeFieldName = "type",
                 jsonNameForType = { it.simpleName!!.removeSuffix("Schema") to it }
             ))
 
+        private val localDateAdapter = object : TypeAdapter<LocalDate>() {
+            override fun write(out: JsonWriter, value: LocalDate?) {
+                out.value(value.toString())
+            }
+
+            override fun read(`in`: JsonReader): LocalDate {
+                return LocalDate.parse(`in`.nextString())
+            }
+        }
+
+        private val localTimeAdapter = object : TypeAdapter<LocalTime>() {
+            override fun write(out: JsonWriter, value: LocalTime?) {
+                out.value(value.toString())
+            }
+
+            override fun read(`in`: JsonReader): LocalTime {
+                return LocalTime.parse(`in`.nextString())
+            }
+        }
 
         private val zonedDateTimeAdapter = object : TypeAdapter<ZonedDateTime>() {
             override fun write(out: JsonWriter, value: ZonedDateTime?) {

kotlin-jira-client/kotlin-jira-client-http/src/main/kotlin/com/linkedplanet/kotlinjiraclient/http/HttpJiraIssueOperator.kt

@@ -306,16 +306,16 @@ class HttpJiraIssueOperator(private val context: HttpJiraClientContext) : JiraIs
                 jsonBody
             }
 
-    private class HttpJiraIssuePage(
+    private data class HttpJiraIssuePage(
         private val maxResults: Number,
         private val startAt: Number,
         private val total: Number,
-        private val issues: List<JsonElement>,
-        val names: JsonElement
+        private val issues: JsonArray,
+        val names: JsonObject
     ) : HttpPage<JsonElement> {
         override fun getMaxResults() = maxResults
         override fun getStartAt() = startAt
         override fun getTotal() = total
-        override fun getValues(): List<JsonElement> = issues
+        override fun getValues(): List<JsonElement> = issues.asList()
     }
 }

kotlin-jira-client/kotlin-jira-client-test-applink/src/test/kotlin/it/JiraApplinkClientTest.kt

@@ -82,18 +82,4 @@ class JiraApplinkClientTest constructor(
     fun initTest() {
         loginAsUser("admin")
     }
-
-//    @Test
-//    fun arghTest() {
-//        val issues: List<Story>? = runBlocking {
-//            issueOperator.getIssuesByJQL("summary ~ \"Test-*\"", parser = ::issueParser).getOrNull()
-//        }
-//        assertThat(issues?.size, equalTo(10))
-//        val keys = 1..10
-//        keys.forEach { searchedKeyIndex ->
-//            val issue = issues?.first { "Test-$searchedKeyIndex" == it.summary }
-//            assertThat(issue?.insightObjectKey, equalTo("IT-1"))
-//            assertThat(issue?.status?.name, equalTo("To Do"))
-//        }
-//    }
 }