remove some kotlin style warnings

Author: HighKo

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/InsightHistoryOperatorTest.kt

@@ -35,8 +35,9 @@ interface InsightHistoryOperatorTest {
     @Test
     fun testHistory() {
         runBlocking {
-            val country = insightObjectOperator.getObjectByName(InsightObjectType.Country.id, "Germany", ::identity).orNull()!!
-            val history = insightHistoryOperator.getHistory(country.id).orNull()!!
+            val country =
+                insightObjectOperator.getObjectByName(InsightObjectType.Country.id, "Germany", ::identity).getOrNull()!!
+            val history = insightHistoryOperator.getHistory(country.id).getOrNull()!!
             assertThat(history.historyItems.isNotEmpty(), equalTo(true))
             assertThat(history.historyItems.last().actor.key, equalTo("admin"))
             assertThat(history.historyItems.last().created, endsWith("Z"))

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/TestUtils.kt

@@ -33,10 +33,14 @@ import org.hamcrest.MatcherAssert.assertThat
  */
 fun <T> Either<InsightClientError, T>.orFail(): T {
     when (this) {
-        is Either.Left<InsightClientError> -> assertThat(this.value.message+" error:"+this.value.error, equalTo("No Error at all!"))
+        is Either.Left<InsightClientError> -> assertThat(
+            "${this.value.message} error:${this.value.error}",
+            equalTo("No Error at all!")
+        )
+
         is Either.Right -> return this.value
     }
-    return (this as Either<InsightClientError, T>).orNull()!!
+    return (this as Either<InsightClientError, T>).getOrNull()!!
 }
 
 fun <T> Either<InsightClientError, T>.asError(): InsightClientError = when (this) {

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/repositories/CompanyRepositoryBasedOnNameMapping.kt

@@ -49,7 +49,7 @@ class CompanyRepositoryBasedOnNameMapping(
     override suspend fun referenceAttributeToValue(attribute: InsightAttribute): Any? {
         val country = (attribute as InsightAttribute.Reference).referencedObjects.first().id
         val eitherCountry = countryOperator.getById(country)
-        return eitherCountry.orNull()
+        return eitherCountry.getOrNull()
     }
 
     override suspend fun attributeToReferencedObjectId(
@@ -63,7 +63,7 @@ class CompanyRepositoryBasedOnNameMapping(
                 name = country.name,
                 toDomain = ::identity
             )
-                .orNull()?.id
+                .getOrNull()?.id
         )
     }
 

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/repositories/TestsWithListRepositoryBasedOnNameMapping.kt

@@ -49,7 +49,7 @@ class TestsWithListRepositoryBasedOnNameMapping(
 
     override suspend fun referenceAttributeToValue(attribute: InsightAttribute): Any? {
         val listOfObjects = (attribute as? InsightAttribute.Reference)?.referencedObjects
-            ?.mapNotNull { simpleObjectRepository.getById(it.id).orNull() }
+            ?.mapNotNull { simpleObjectRepository.getById(it.id).getOrNull() }
         return listOfObjects
     }