fix ktor client tests

Author: HighKo

kotlin-http-client/kotlin-http-client-ktor/src/main/kotlin/com/linkedplanet/kotlinhttpclient/ktor/KtorHttpClient.kt

@@ -141,6 +141,7 @@ class KtorHttpClient(
             }
         ) {
             url("$baseUrl$url")
+            header("X-Atlassian-Token", "no-check")
             header("Connection", "keep-alive")
             header("Cache-Control", "no-cache")
         }

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/AuthenticatedJiraHttpClientFactory.kt

@@ -20,10 +20,8 @@
 package com.linkedplanet.kotlininsightclient
 
 import arrow.core.Either
-import arrow.core.left
 import arrow.core.right
 import com.google.gson.Gson
-import com.linkedplanet.kotlininsightclient.api.error.AuthenticationError
 import com.linkedplanet.kotlininsightclient.api.error.InsightClientError
 import org.http4k.client.Java8HttpClient
 import org.http4k.core.Body
@@ -36,6 +34,7 @@ import org.http4k.core.then
 import org.http4k.filter.ClientFilters
 import org.http4k.filter.cookie.BasicCookieStorage
 import org.http4k.filter.cookie.CookieStorage
+import java.util.*
 
 /**
  * Provides access to Jira itself via a logged in AuthenticatedHttpHandler
@@ -51,26 +50,29 @@ class AuthenticatedJiraHttpClientFactory(
     private val httpHandler: HttpHandler = ClientFilters.Cookies(storage = storage).then(Java8HttpClient())
     private val gson = Gson()
 
-    fun login(credentials: Credentials) : Either<InsightClientError, AuthenticatedHttpHandler> {
+    fun login(credentials: Credentials): Either<InsightClientError, AuthenticatedHttpHandler> {
+        val username = credentials.username
+        val password = credentials.password
         val body = gson.toJson(credentials)
         val request = Request(Method.POST, "$jiraOrigin/rest/auth/1/session")
             .header("content-type", "application/json")
             .body(Body(body))
-
         val loginResponse = httpHandler(request)
         if (loginResponse.status != Status.OK) {
-            return AuthenticationError(
-                "Login failed with HTTP StatusCode:${loginResponse.status.code}"
-            ).left()
-        } else {
-            val privateHandler = object : AuthenticatedHttpHandler, HttpHandler by httpHandler {
-                override fun getWithRelativePath(path: String): Response {
-                    val absolutePath = "$jiraOrigin$path"
-                    return this(Request(Method.GET, absolutePath))
-                }
+            println("Continue despite 'session' login failing with HTTP StatusCode:${loginResponse.status.code}")
+        }
+        val privateHandler = object : AuthenticatedHttpHandler, HttpHandler by httpHandler {
+            override fun getWithRelativePath(path: String): Response {
+                val absolutePath = "$jiraOrigin$path"
+                val getRequest = Request(Method.GET, absolutePath)
+                    .header(
+                        "Authorization",
+                        "Basic ${Base64.getEncoder().encodeToString("$username:$password".toByteArray())}"
+                    )
+                return this(getRequest)
             }
-            return privateHandler.right()
         }
+        return privateHandler.right()
     }
 }
 

kotlin-insight-client/kotlin-insight-client-test-base/src/main/kotlin/com/linkedplanet/kotlininsightclient/InsightObjectOperatorTest.kt

@@ -266,7 +266,7 @@ interface InsightObjectOperatorTest {
         name = "testObjectWithAllDefaultTypes",
         testBoolean = false,
         testInteger = 72,
-        testFloat = 3.12345678901234, // only double precision does survive this roundtrip
+        testFloat = 3.123456789012, // A longer number does not survice the official REST calls
         testDate = LocalDate.parse("1984-04-01"),
         testDateTime = ZonedDateTime.parse("1983-12-07T14:55:24Z"),
         testUrl = setOf("http://127.0.0.1", "http://localhost"),