Skip to content

Commit 15f4c8c

Browse files
Merge pull request #25 from linked-planet/dev
small style fixes
2 parents 5434c9a + 97353c1 commit 15f4c8c

File tree

6 files changed

+615
-408
lines changed

6 files changed

+615
-408
lines changed

library/src/components/inputs/Inputs.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -137,9 +137,9 @@ const Input = forwardRef(
137137
className={twJoin(
138138
"inline-flex",
139139
inputBaseStyle,
140-
appearance !== "subtle"
141-
? "border-input-border bg-input"
142-
: "border-transparent bg-transparent",
140+
appearance === "subtle"
141+
? "border-transparent bg-transparent"
142+
: undefined,
143143
"data-[active=true]:bg-input-active hover:data-[active=true]:bg-input-active",
144144
"hover:bg-input-hovered hover:focus-within:bg-input-active focus-within:bg-input-active",
145145
"data-[disabled=true]:bg-disabled data-[disabled=true]:cursor-not-allowed data-[disabled=true]:border-transparent",

library/src/components/inputs/Select.tsx

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,6 @@ function useClassNamesConfig<ValueType, IsMulti extends boolean = boolean>(
9797
...classNamesConfig,
9898
control: (provided) =>
9999
twMerge(
100-
classNamesConfig?.control?.(provided),
101100
twJoin(
102101
inputBaseStyle,
103102
"px-2 flex items-center",
@@ -114,13 +113,14 @@ function useClassNamesConfig<ValueType, IsMulti extends boolean = boolean>(
114113
? "bg-input hover:bg-input-hovered"
115114
: undefined,
116115
),
116+
classNamesConfig?.control?.(provided),
117117
className,
118118
),
119119
menu: (provided) =>
120120
twMerge(menuStyles, classNamesConfig?.menu?.(provided)),
121121
clearIndicator: (provided) =>
122122
twMerge(
123-
"w-4 cursor-pointer text-text-subtlest hover:text-text",
123+
"w-4 cursor-pointer text-text-subtlest hover:text-text focus-visible:outline-selected-bold focus-visible:outline-2 focus-visible:outline",
124124
classNamesConfig?.clearIndicator?.(provided),
125125
),
126126
dropdownIndicator: (provided) =>
@@ -162,7 +162,7 @@ function useClassNamesConfig<ValueType, IsMulti extends boolean = boolean>(
162162
multiValue: (provided) => {
163163
return twJoin(
164164
twMerge(
165-
"bg-neutral w-auto rounded-sm pl-1 mr-2 my-0.5 text-text",
165+
"bg-neutral w-auto rounded-sm pl-1 mr-2 my-1 text-text",
166166
provided.isDisabled
167167
? "bg-disabled text-disabled-text"
168168
: undefined,
@@ -173,7 +173,7 @@ function useClassNamesConfig<ValueType, IsMulti extends boolean = boolean>(
173173
},
174174
multiValueRemove: (provided) =>
175175
twMerge(
176-
"hover:bg-danger-hovered flex-none active:bg-danger-pressed focus-visible:outline-offset-0 px-1 cursor-pointer ml-1 flex items-center rounded-r-sm " as const,
176+
"hover:bg-danger-hovered flex-none active:bg-danger-pressed focus-visible:outline-offset-0 focus-visible:outline-selected-bold focus-visible:outline focus-visible:outline-2 px-1 cursor-pointer ml-1 flex items-center rounded-r-sm " as const,
177177
classNamesConfig?.multiValueRemove?.(provided),
178178
),
179179
option: (provided) =>
@@ -210,10 +210,8 @@ const customStyles = {
210210
control: (provided: CSSObjectWithLabel) => ({
211211
...provided,
212212
cursor: "pointer",
213-
minHeight: "2rem",
214-
//borderWidth: "2px",
213+
minHeight: "2.25rem", // this is min-h-9 as set in the inputBaseStyle
215214
flexWrap: "nowrap" as const,
216-
//height: "1.83rem",
217215
}),
218216
}
219217

library/src/components/styleHelper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ export const overlayBaseStyle =
44
"bg-surface-overlay relative shadow-overlay border-border border-solid border z-50 rounded overflow-auto max-h-full" /* only-x-auto to allow for horizontal scrolling but do not cut off the outline */
55

66
export const inputBaseStyle = twJoin(
7-
"min-h-8 rounded box-border w-full relative border border-input-border border-solid focus-within:border-transparent data-[active=true]:border-transparent data-[invalid=true]:border-transparent ease-in-out transition duration-200 p-0 ",
7+
"min-h-9 rounded box-border w-full relative border-[0.88px] border-input-border bg-input focus-within:bg-input-active border-solid focus-within:border-transparent data-[active=true]:border-transparent data-[invalid=true]:border-transparent ease-in-out transition duration-200 p-0 ",
88
"before:pointer-events-none before:z-10 before:content-[''] before:absolute before:-inset-[0.5px] before:box-border before:rounded before:border-2 before:border-solid before:border-transparent",
99
"focus-within:before:border-input-border-focused",
1010
"data-[active=true]:before:border-input-border-focused",

0 commit comments

Comments
 (0)