Skip to content

Commit b948089

Browse files
Merge pull request #106 from linked-planet/dev
Loadingbutton - fix for size overwritten by important
2 parents b68ded3 + 7587457 commit b948089

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

library/src/components/Button.tsx

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -191,15 +191,15 @@ Button.displayName = "LPButton"
191191
export { Button }
192192

193193
const loadingSpinnerClassNames: { [appearance in ButtonAppearance]: string } = {
194-
primary: "border-t-text-inverse",
195-
default: "border-t-border-bold",
196-
subtle: "border-t-border-bold",
197-
link: "border-t-border-bold",
198-
"subtle-link": "border-t-border-bold",
199-
warning: "border-t-text-inverse",
200-
danger: "border-t-text-inverse",
201-
success: "border-t-text-inverse",
202-
information: "border-t-text-inverse",
194+
primary: "border-t-text-inverse border-2",
195+
default: "border-t-border-bold border-2",
196+
subtle: "border-t-border-bold border-2",
197+
link: "border-t-border-bold border-2",
198+
"subtle-link": "border-t-border-bold border-2",
199+
warning: "border-t-text-inverse border-2",
200+
danger: "border-t-text-inverse border-2",
201+
success: "border-t-text-inverse border-2",
202+
information: "border-t-text-inverse border-2",
203203
}
204204

205205
export const LoadingButton = ({
@@ -242,6 +242,7 @@ export const LoadingButton = ({
242242
height: `${height * 0.8}px`,
243243
width: `${height * 0.8}px`,
244244
}}
245+
size="unset"
245246
/>
246247
</div>
247248
</Button>

library/src/components/LoadingSpinner.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import type { CSSProperties } from "react"
22
import { twMerge } from "tailwind-merge"
3-
type Size = "xsmall" | "small" | "medium" | "large" | "xlarge"
3+
type Size = "xsmall" | "small" | "medium" | "large" | "xlarge" | "unset"
44

55
const xsmallStyle = "size-2 border"
66
const smallStyle = "size-4 border-2"
@@ -14,6 +14,7 @@ const sizeStyles: { [size in Size]: string } = {
1414
medium: mediumStyle,
1515
large: largeStyle,
1616
xlarge: xlargeStyle,
17+
unset: "",
1718
}
1819

1920
export function LoadingSpinner({

0 commit comments

Comments
 (0)