fixing eslint problems

Philipp Karlsson · Philipp Karlsson · commit d013f9d93927 · 2023-02-14T11:43:37.000+01:00
diff --git a/.idea/inspectionProfiles/Project_Default.xml b/.idea/inspectionProfiles/Project_Default.xml
diff --git a/showcase/package.json b/showcase/package.json
@@ -23,7 +23,7 @@
     "reload": "npm install && install-local-dependencies",
     "generate": "node copySources.js",
     "eject": "react-scripts eject",
-    "eslint": "eslint src/index.tsx"
+    "eslint": "eslint src"
   },
   "eslintConfig": {
     "extends": [
diff --git a/showcase/src/components/ShowcaseLeftSidebar.tsx b/showcase/src/components/ShowcaseLeftSidebar.tsx
@@ -8,7 +8,6 @@ import {
     Section,
     SideNavigation
 } from "@atlaskit/side-navigation";
-import SearchIcon from "@atlaskit/icon/glyph/search";
 
 function ShowcaseLeftSidebar() {
 
diff --git a/showcase/src/components/ShowcaseWrapperItem.tsx b/showcase/src/components/ShowcaseWrapperItem.tsx
@@ -1,4 +1,4 @@
-import {ReactNode, useState} from "react";
+import {ReactNode} from "react";
 import Tabs, {Tab, TabList, TabPanel} from "@atlaskit/tabs"
 import {CodeBlock} from "@atlaskit/code";
 
@@ -24,7 +24,7 @@ function extractSourceCodeExample(overallSourceCode: string, sourceCodeExampleId
     const exampleCodeEndMarker = "// endregion: " + sourceCodeExampleId;
     if (overallSourceCode.indexOf(exampleCodeStartMarker) && overallSourceCode.indexOf(exampleCodeEndMarker)) {
         const result = overallSourceCode.substring(
-            overallSourceCode.indexOf(exampleCodeStartMarker)+exampleCodeStartMarker.length,
+            overallSourceCode.indexOf(exampleCodeStartMarker) + exampleCodeStartMarker.length,
             overallSourceCode.indexOf(exampleCodeEndMarker)
         )
         return result
@@ -34,8 +34,6 @@ function extractSourceCodeExample(overallSourceCode: string, sourceCodeExampleId
 
 function ShowcaseWrapperItem(props: ShowcaseWrapperItemProps) {
 
-    const [selectedTab, setSelectedTab] = useState(0)
-
     let code = ""
     console.info("OverallSourceCode, SourceCodeExampleId", props.overallSourceCode, props.sourceCodeExampleId)
     if (props.overallSourceCode != null && props.overallSourceCode != "" && props.sourceCodeExampleId != null && props.sourceCodeExampleId != "") {
@@ -51,13 +49,13 @@ function ShowcaseWrapperItem(props: ShowcaseWrapperItemProps) {
             <h3>{props.name}</h3>
             <div style={{fontWeight: "lighter", fontSize: "0.8rem"}}>
                 <span>Packages: </span>
-                {props.packages.map((pack, index, array) => {
+                {props.packages.map((pack) => {
                     return (<a href={pack.url} target="_blank">{pack.name}</a>)
                 })}
             </div>
 
             <div style={{marginLeft: "-8px"}}>
-                <Tabs id={props.name+"-tabs"}>
+                <Tabs id={props.name + "-tabs"}>
                     <TabList>
                         <Tab>Example</Tab>
                         <Tab>Example Source</Tab>
@@ -73,10 +71,10 @@ function ShowcaseWrapperItem(props: ShowcaseWrapperItemProps) {
                     </TabPanel>
                     <TabPanel>
                         <div style={{width: "100%"}}>
-                            { code == "" &&
+                            {code == "" &&
                                 <span>No sources found...</span>
                             }
-                            { code != "" &&
+                            {code != "" &&
                                 <div style={{width: "100%"}}>
                                     <CodeBlock
                                         text={code}
diff --git a/showcase/src/components/showcase/wrapper/FormShowcase.tsx b/showcase/src/components/showcase/wrapper/FormShowcase.tsx
@@ -19,8 +19,6 @@ function FormShowcase(props: ShowcaseProps) {
         favoriteColorCreatable: string
     }
 
-    const colors: string[] = ["BLUE", "RED"]
-
     const initFormData = {
         name: "Carl",
         readonlyField: "Read-only Field",
diff --git a/showcase/src/components/showcase/wrapper/IconShowcase.tsx b/showcase/src/components/showcase/wrapper/IconShowcase.tsx
@@ -1,6 +1,5 @@
 import React from "react";
 import ShowcaseWrapperItem, {ShowcaseProps} from "../../ShowcaseWrapperItem";
-import Flag from "@atlaskit/flag";
 import ArrowDownIcon from "@atlaskit/icon/glyph/arrow-down";
 import BulletListIcon from "@atlaskit/icon/glyph/bullet-list";
 import CheckCircleIcon from "@atlaskit/icon/glyph/check-circle";
diff --git a/showcase/src/components/showcase/wrapper/PaginationShowcase.tsx b/showcase/src/components/showcase/wrapper/PaginationShowcase.tsx
@@ -12,7 +12,7 @@ function PaginationShowcase(props: ShowcaseProps) {
             defaultSelectedIndex={0}
             max={10}
             selectedIndex={selectedPage}
-            onChange={(event, page, analyticsEvent) => setSelectedPage(page-1)}
+            onChange={(event, page) => setSelectedPage(page-1)}
         />
     )
     // endregion: pagination
diff --git a/showcase/src/components/showcase/wrapper/TableTreeShowcase.tsx b/showcase/src/components/showcase/wrapper/TableTreeShowcase.tsx
@@ -10,13 +10,6 @@ function TableTreeShowcase(props: ShowcaseProps) {
         description: string
     }
 
-    interface BookTreeItem {
-        id: string
-        content: BookData
-        children: TableTreeItem[]
-        hasChildren: boolean
-    }
-
     interface TableTreeItem {
         id: string
         title: string
diff --git a/showcase/src/page/WrappersPage.tsx b/showcase/src/page/WrappersPage.tsx
@@ -1,5 +1,4 @@
 import React, {useEffect, useState} from "react";
-import {CodeBlock} from "@atlaskit/code";
 import AvatarShowcase from "../components/showcase/wrapper/AvatarShowcase";
 import AwesomeSliderShowcase from "../components/showcase/wrapper/AwesomeSliderShowcase";
 import BadgeShowcase from "../components/showcase/wrapper/BadgeShowcase";
@@ -50,50 +49,50 @@ function WrappersPage() {
         <div>
             <h1>Wrappers</h1>
 
-            <AvatarShowcase overallSourceCode={overallSourceCode} />
+            <AvatarShowcase overallSourceCode={overallSourceCode}/>
 
-            <AwesomeSliderShowcase overallSourceCode={overallSourceCode} />
+            <AwesomeSliderShowcase overallSourceCode={overallSourceCode}/>
 
-            <BadgeShowcase overallSourceCode={overallSourceCode} />
+            <BadgeShowcase overallSourceCode={overallSourceCode}/>
 
-            <ButtonShowcase overallSourceCode={overallSourceCode} />
+            <ButtonShowcase overallSourceCode={overallSourceCode}/>
 
-            <BannerShowcase overallSourceCode={overallSourceCode} />
+            <BannerShowcase overallSourceCode={overallSourceCode}/>
 
-            <CalendarShowcase overallSourceCode={overallSourceCode} />
+            <CalendarShowcase overallSourceCode={overallSourceCode}/>
 
-            <CheckboxShowcase overallSourceCode={overallSourceCode} />
+            <CheckboxShowcase overallSourceCode={overallSourceCode}/>
 
-            <CodeBlockShowcase overallSourceCode={overallSourceCode} />
+            <CodeBlockShowcase overallSourceCode={overallSourceCode}/>
 
-            <DateTimePickerShowcase overallSourceCode={overallSourceCode} />
+            <DateTimePickerShowcase overallSourceCode={overallSourceCode}/>
 
-            <DateTimeRangePickerShowcase overallSourceCode={overallSourceCode} />
+            <DateTimeRangePickerShowcase overallSourceCode={overallSourceCode}/>
 
-            <DropDownMenuShowcase overallSourceCode={overallSourceCode} />
+            <DropDownMenuShowcase overallSourceCode={overallSourceCode}/>
 
-            <EmptyStateShowcase overallSourceCode={overallSourceCode} />
+            <EmptyStateShowcase overallSourceCode={overallSourceCode}/>
 
-            <FlagShowcase overallSourceCode={overallSourceCode} />
-            <FormShowcase overallSourceCode={overallSourceCode} />
-            <IconShowcase overallSourceCode={overallSourceCode} />
-            <JoyrideShowcase overallSourceCode={overallSourceCode} />
-            <LozengeShowcase overallSourceCode={overallSourceCode} />
-            <ModalShowcase overallSourceCode={overallSourceCode} />
-            <PaginationShowcase overallSourceCode={overallSourceCode} />
-            <PanelShowcase overallSourceCode={overallSourceCode} />
-            <PopupShowcase overallSourceCode={overallSourceCode} />
-            <SelectShowcase overallSourceCode={overallSourceCode} />
-            <TabsShowcase overallSourceCode={overallSourceCode} />
-            <TagShowcase overallSourceCode={overallSourceCode} />
-            <DynamicTableShowcase overallSourceCode={overallSourceCode} />
-            <TableTreeShowcase overallSourceCode={overallSourceCode} />
-            <TextAreaShowcase overallSourceCode={overallSourceCode} />
-            <TextFieldShowcase overallSourceCode={overallSourceCode} />
-            <ToggleShowcase overallSourceCode={overallSourceCode} />
-            <TooltipShowcase overallSourceCode={overallSourceCode} />
+            <FlagShowcase overallSourceCode={overallSourceCode}/>
+            <FormShowcase overallSourceCode={overallSourceCode}/>
+            <IconShowcase overallSourceCode={overallSourceCode}/>
+            <JoyrideShowcase overallSourceCode={overallSourceCode}/>
+            <LozengeShowcase overallSourceCode={overallSourceCode}/>
+            <ModalShowcase overallSourceCode={overallSourceCode}/>
+            <PaginationShowcase overallSourceCode={overallSourceCode}/>
+            <PanelShowcase overallSourceCode={overallSourceCode}/>
+            <PopupShowcase overallSourceCode={overallSourceCode}/>
+            <SelectShowcase overallSourceCode={overallSourceCode}/>
+            <TabsShowcase overallSourceCode={overallSourceCode}/>
+            <TagShowcase overallSourceCode={overallSourceCode}/>
+            <DynamicTableShowcase overallSourceCode={overallSourceCode}/>
+            <TableTreeShowcase overallSourceCode={overallSourceCode}/>
+            <TextAreaShowcase overallSourceCode={overallSourceCode}/>
+            <TextFieldShowcase overallSourceCode={overallSourceCode}/>
+            <ToggleShowcase overallSourceCode={overallSourceCode}/>
+            <TooltipShowcase overallSourceCode={overallSourceCode}/>
             {/*<LPEditorShowcase overallSourceCode={overallSourceCode} />*/}
-            <MenuShowcase overallSourceCode={overallSourceCode} />
+            <MenuShowcase overallSourceCode={overallSourceCode}/>
 
         </div>
     )

Original file line number	Diff line number	Diff line change
`@@ -19,8 +19,6 @@ function FormShowcase(props: ShowcaseProps) {`
`19`	`19`	`favoriteColorCreatable: string`
`20`	`20`	`}`
`21`	`21`
`22`		`- const colors: string[] = ["BLUE", "RED"]`
`23`		`-`
`24`	`22`	`const initFormData = {`
`25`	`23`	`name: "Carl",`
`26`	`24`	`readonlyField: "Read-only Field",`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ function PaginationShowcase(props: ShowcaseProps) {`
`12`	`12`	`defaultSelectedIndex={0}`
`13`	`13`	`max={10}`
`14`	`14`	`selectedIndex={selectedPage}`
`15`		`- onChange={(event, page, analyticsEvent) => setSelectedPage(page-1)}`
	`15`	`+ onChange={(event, page) => setSelectedPage(page-1)}`
`16`	`16`	`/>`
`17`	`17`	`)`
`18`	`18`	`// endregion: pagination`