Skip to content

Commit e5c1483

Browse files
Merge pull request #31 from linked-planet/dev
Dev
2 parents a4dd673 + 9990dc4 commit e5c1483

File tree

4 files changed

+104
-114
lines changed

4 files changed

+104
-114
lines changed

library/src/components/DropdownMenu.tsx

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -5,26 +5,20 @@ import ChevronRightIcon from "@atlaskit/icon/glyph/chevron-right"
55
import ChevronUpIcon from "@atlaskit/icon/glyph/chevron-up"
66
import RadioIcon from "@atlaskit/icon/glyph/radio"
77
import * as RDd from "@radix-ui/react-dropdown-menu"
8-
import {
9-
type RefObject,
10-
forwardRef,
11-
useMemo,
12-
useRef,
13-
type ForwardedRef,
14-
} from "react"
8+
import { forwardRef, useMemo, useRef, type ForwardedRef } from "react"
159
import { twJoin, twMerge } from "tailwind-merge"
1610
import { getPortal } from "../utils"
1711
import { Button, type ButtonProps } from "./Button"
1812
import { overlayBaseStyle } from "./styleHelper"
1913
import { IconSizeHelper } from "./IconSizeHelper"
2014

2115
const commonStyles =
22-
"pl-1 pr-4 py-2.5 flex border-solid items-center outline-none border-2 border-transparent box-border focus-visible:outline-0 w-full cursor-default focus-visible:outline-none focus-visible:border-solid focus-visible:border-selected-border" as const
16+
"pl-1 pr-4 py-2.5 flex border-solid items-center outline-none border-l-2 border-y-0 border-r-0 focus-visible:border-l-2 border-transparent box-border focus-visible:outline-0 w-full cursor-default focus-visible:outline-none focus-visible:border-selected-border" as const
2317
const disabledStyles = "text-disabled-text cursor-not-allowed" as const
2418
const selectedStyles =
25-
"bg-selected-subtle hover:bg-selected-subtle-hovered active:bg-selected-subtle-pressed text-selected-subtle-text" as const
19+
"data-[selected=true]:bg-selected-subtle data-[selected=true]:hover:bg-selected-subtle-hovered data-[selected=true]:border-l-selected-bold data-[selected=true]:active:bg-selected-subtle-pressed data-[selected=true]:text-selected-subtle-text" as const
2620
const normalStyles =
27-
"hover:bg-surface-overlay-hovered hover:border-l-selected-bold active:bg-surface-overlay-pressed cursor-pointer" as const
21+
"hover:bg-surface-overlay-hovered focus-visible:bg-surface-overlay-hovered hover:border-l-selected-border active:bg-surface-overlay-pressed cursor-pointer" as const
2822

2923
const descriptionStyle = "text-text-subtlest text-[12px] leading-4 h-4" as const
3024

@@ -74,13 +68,12 @@ function Item({
7468
className={twMerge(
7569
commonStyles,
7670
!disabled && !selected ? normalStyles : undefined,
77-
selected
78-
? `${selectedStyles} border-l-selected-bold`
79-
: undefined,
71+
selected ? selectedStyles : undefined,
8072
disabled ? disabledStyles : undefined,
8173
className,
8274
)}
8375
onClick={onClick}
76+
data-selected={selected}
8477
style={style}
8578
{...props}
8679
>

library/src/components/inputs/Select.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -183,11 +183,11 @@ function useClassNamesConfig<ValueType, IsMulti extends boolean = boolean>(
183183
? "bg-selected-subtle border-l-selected-border"
184184
: undefined,
185185
provided.isFocused
186-
? "border-l-selected-border bg-surface-overlay-hovered"
186+
? "border-l-selected-border focus-visible:border-l-selected-border bg-surface-overlay-hovered"
187187
: undefined,
188188
provided.isDisabled
189189
? "text-disabled-text"
190-
: "hover:border-l-selected-border hover:bg-surface-overlay-hovered active:bg-surface-overlay-pressed",
190+
: "hover:border-l-selected-border focus-visible:border-l-selected-border hover:bg-surface-overlay-hovered active:bg-surface-overlay-pressed",
191191
classNamesConfig?.option?.(provided),
192192
),
193193
groupHeading: (provided) =>

0 commit comments

Comments
 (0)