Merge pull request #148 from linked-planet/dev

Dev

Author: marcus-wishes

library/src/components/Modal.tsx

@@ -143,8 +143,6 @@ function Container({
 		],
 	)
 
-	console.log("portalContainer", portalContainer?.parentElement?.parentNode)
-
 	return (
 		<RDialog.Root
 			open={open}

library/src/layouting/AppLayout.tsx

@@ -32,7 +32,8 @@ export function initTopNavigationHeight() {
 		console.info("UIKitTs - Top navigation height set to:", topNavHeight)
 		document.documentElement.style.setProperty(
 			topNavigationHeightVar,
-			`${topNavHeight}px`,
+			//`${topNavHeight}px`, // this seems to be wrong and moving the page downwards
+			"0",
 		)
 	}
 

library/src/utils/getPortal.ts

@@ -19,15 +19,18 @@ export function getPortal(
 	if (!insidePortalContainerID) {
 		throw new Error("No portal container id provided")
 	}
+
 	let portalNode = shadowRoot
 		? shadowRoot.getElementById(portalContainerID)
 		: document.getElementById(portalContainerID)
+	// probably this should go to the host document of the shadowRoot
+
 	if (!portalNode) {
 		console.log("creating portal node with id:", portalContainerID)
 		portalNode = document.createElement("div")
 		portalNode.setAttribute("id", portalContainerID)
 		portalNode.style.setProperty("z-index", "511") // the atlaskit portal has 510
-		portalNode.style.setProperty("position", "fixed")
+		portalNode.style.setProperty("position", "absolute") // cannot set this to fixed or things like dropdowns menus will be positioned wrongly on scroll
 		portalNode.style.setProperty("inset", "0")
 		portalNode.style.setProperty("pointer-events", "none")
 		if (shadowRoot) {