Skip to content

Commit 5dc0c2b

Browse files
authored
Bug fix: handle capitals in Kafka topics (#50)
1 parent 6e1b6c0 commit 5dc0c2b

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

hoptimator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopic.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,14 @@
22

33
import com.linkedin.hoptimator.catalog.Resource;
44

5-
import java.util.Optional;
6-
import java.util.Collections;
5+
import java.util.Locale;
76
import java.util.Map;
87

98
class KafkaTopic extends Resource {
10-
public KafkaTopic(String topicName, Map<String, String> clientOverrides) {
9+
KafkaTopic(String topicName, Map<String, String> clientOverrides) {
1110
super("KafkaTopic");
1211
export("topicName", topicName);
12+
export("topicNameLowerCase", topicName.toLowerCase(Locale.ROOT));
1313
export("clientOverrides", clientOverrides);
1414
}
1515
}

hoptimator-kafka-adapter/src/main/java/com/linkedin/hoptimator/catalog/kafka/KafkaTopicAcl.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22

33
import com.linkedin.hoptimator.catalog.Resource;
44

5+
import java.util.Locale;
6+
57
class KafkaTopicAcl extends Resource {
68
public KafkaTopicAcl(String topicName, String principal, String method) {
79
super("KafkaTopicAcl");
810
export("topicName", topicName);
11+
export("topicNameLowerCase", topicName.toLowerCase(Locale.ROOT));
912
export("principal", principal);
1013
export("method", method);
1114
}

hoptimator-kafka-adapter/src/main/resources/KafkaTopic.yaml.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
apiVersion: hoptimator.linkedin.com/v1alpha1
22
kind: KafkaTopic
33
metadata:
4-
name: {{topicName}}
4+
name: {{topicNameLowerCase}}
55
namespace: {{pipeline.namespace}}
66
spec:
77
topicName: {{topicName}}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
apiVersion: hoptimator.linkedin.com/v1alpha1
22
kind: Acl
33
metadata:
4-
name: {{topicName}}-acl-{{id}}
4+
name: {{topicNameLowerCase}}-acl-{{id}}
55
namespace: {{pipeline.namespace}}
66
spec:
77
resource:
88
kind: KafkaTopic
9-
name: {{topicName}}
9+
name: {{topicNameLowerCase}}
1010
method: {{method}}
1111
principal: {{principal}}

0 commit comments

Comments
 (0)