Fix NPE (#62)

ryannedolan · web-flow · commit 8edcd27a2e48 · 2024-03-13T21:16:01.000Z
diff --git a/hoptimator-operator/src/main/java/com/linkedin/hoptimator/operator/subscription/SubscriptionReconciler.java b/hoptimator-operator/src/main/java/com/linkedin/hoptimator/operator/subscription/SubscriptionReconciler.java
@@ -316,7 +316,7 @@ private static boolean isReady(DynamicKubernetesObject obj) {
   // Whether status has diverged from spec (i.e. we need to re-plan the pipeline)
   private static boolean diverged(V1alpha1SubscriptionSpec spec, V1alpha1SubscriptionStatus status) {
     return status.getSql() == null || !status.getSql().equals(spec.getSql())
-        || !status.getHints().equals(spec.getHints());
+        || status.getHints() == null || !status.getHints().equals(spec.getHints());
   }
 
   // Fetch attributes from downstream controllers

Original file line number	Diff line number	Diff line change
`@@ -316,7 +316,7 @@ private static boolean isReady(DynamicKubernetesObject obj) {`
`316`	`316`	`// Whether status has diverged from spec (i.e. we need to re-plan the pipeline)`
`317`	`317`	`private static boolean diverged(V1alpha1SubscriptionSpec spec, V1alpha1SubscriptionStatus status) {`
`318`	`318`	`return status.getSql() == null \|\| !status.getSql().equals(spec.getSql())`
`319`		`- \|\| !status.getHints().equals(spec.getHints());`
	`319`	`+ \|\| status.getHints() == null \|\| !status.getHints().equals(spec.getHints());`
`320`	`320`	`}`
`321`	`321`
`322`	`322`	`// Fetch attributes from downstream controllers`