Remove latest v4 test to reduce cost (#1098)

## Summary
<!--- This is a required section; please describe the main purpose of
this proposed code change. --->
We have too many tests right now. It costs too much.
<!---
## Details
This is an optional section; is there anything specific that reviewers
should be aware of?
--->

## Testing Done
<!--- This is a required section; please describe how this change was
tested. --->

<!-- 
Replace BLANK with your device type. For example, A100-80G-PCIe

Complete the following tasks before sending your PR, and replace `[ ]`
with
`[x]` to indicate you have done them. 
-->

- Hardware Type: <BLANK>
- [ ] run `make test` to ensure correctness
- [x] run `make checkstyle` to ensure code style
- [ ] run `make test-convergence` to ensure convergence

Author: Mecoli1219

.github/workflows/nvi-ci.yml

@@ -148,55 +148,3 @@ jobs:
     - name: Run tests
       run: |
         modal run dev.modal.tests::liger_oldest_v4_convergence_tests
-
-  correctness-tests-with-transformers-4-57-6:
-    runs-on: ubuntu-latest
-    needs: [checkstyle]
-    env:
-      MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
-      MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v6
-
-    - name: Set up Python
-      uses: actions/setup-python@v6
-      with:
-        python-version: '3.10'
-
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        pip install modal
-
-    - name: Run tests
-      run: |
-        modal run dev.modal.tests::liger_latest_v4_correctness_tests
-
-
-
-  convergence-tests-with-transformers-4-57-6:
-    runs-on: ubuntu-latest
-    needs: [checkstyle]
-    env:
-      MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
-      MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
-
-    steps:
-    - name: Checkout code
-      uses: actions/checkout@v6
-
-    - name: Set up Python
-      uses: actions/setup-python@v6
-      with:
-        python-version: '3.10'
-
-    - name: Install dependencies
-      run: |
-        python -m pip install --upgrade pip
-        pip install modal
-
-    - name: Run tests
-      run: |
-        modal run dev.modal.tests::liger_latest_v4_convergence_tests

dev/modal/tests.py

@@ -84,41 +84,3 @@ def liger_oldest_v4_convergence_tests():
 
 
 latest_v4_app = modal.App("liger_latest_v4_tests", image=image)  # 4.57.6
-
-
-@latest_v4_app.function(gpu="H100!", image=repo, timeout=90 * 60)
-def liger_latest_v4_correctness_tests():
-    import subprocess
-
-    subprocess.run(
-        ["uv pip install -e '.[dev]' --system"],
-        check=True,
-        shell=True,
-        cwd=REMOTE_ROOT_PATH,
-    )
-    subprocess.run(
-        [f"uv pip install 'transformers>={OLDEST_SUPPORTED_TRANSFORMERS_V4_VERSION}, <5.0.0' --system"],
-        check=True,
-        shell=True,
-        cwd=REMOTE_ROOT_PATH,
-    )
-    subprocess.run(["make test"], check=True, shell=True, cwd=REMOTE_ROOT_PATH)
-
-
-@latest_v4_app.function(gpu="H100!", image=repo, timeout=90 * 60)
-def liger_latest_v4_convergence_tests():
-    import subprocess
-
-    subprocess.run(
-        ["uv pip install -e '.[dev]' --system"],
-        check=True,
-        shell=True,
-        cwd=REMOTE_ROOT_PATH,
-    )
-    subprocess.run(
-        [f"uv pip install 'transformers>={OLDEST_SUPPORTED_TRANSFORMERS_V4_VERSION}, <5.0.0' --system"],
-        check=True,
-        shell=True,
-        cwd=REMOTE_ROOT_PATH,
-    )
-    subprocess.run(["make test-convergence"], check=True, shell=True, cwd=REMOTE_ROOT_PATH)