Commit 1fdb668
authored
Update checkstyle and fix the format issue (#1071)
Summary
----------
1. I found that the benchmark_fused_add_rms_norm.py format issue led to
the collective failure of CI. fix it first.
2. The checkstyle script has been updated to enable it to display the
modified logs.
Test
```
>> make checkstyle
ruff check --output-format=concise .; ruff_check_status=$?; \
ruff format --check --diff .; ruff_format_status=$?; \
ruff check . --fix; \
ruff format .; \
if [ $ruff_check_status -ne 0 ] || [ $ruff_format_status -ne 0 ]; then \
exit 1; \
fi
All checks passed!
--- benchmark/scripts/benchmark_fused_add_rms_norm.py
+++ benchmark/scripts/benchmark_fused_add_rms_norm.py
@@ -103,7 +103,7 @@
elif mode == "backward":
y, s = y_fwd()
ms_50, ms_20, ms_80 = triton.testing.do_bench(
- lambda: (torch.autograd.backward((y, s), (dy, ds), retain_graph=True)),
+ lambda: torch.autograd.backward((y, s), (dy, ds), retain_graph=True),
grad_to_none=[x, r],
rep=500,
quantiles=QUANTILES,
1 file would be reformatted, 226 files already formatted
All checks passed!
1 file reformatted, 226 files left unchanged
make: *** [checkstyle] Error 1
```1 parent 83cdcf8 commit 1fdb668
2 files changed
+3
-4
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
17 | 17 | | |
18 | 18 | | |
19 | 19 | | |
20 | | - | |
21 | | - | |
| 20 | + | |
| 21 | + | |
22 | 22 | | |
23 | 23 | | |
24 | 24 | | |
| |||
71 | 71 | | |
72 | 72 | | |
73 | 73 | | |
74 | | - | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
103 | 103 | | |
104 | 104 | | |
105 | 105 | | |
106 | | - | |
| 106 | + | |
107 | 107 | | |
108 | 108 | | |
109 | 109 | | |
| |||
0 commit comments