Skip to content

Commit 2b63217

Browse files
authored
Renaming Nvidia tests to allow enabling them from rules. (#1107)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> 1. Removing checkstyle from GPU tests as they are removed from workflows. 2. Renaming Nvidia GPU tests to they can be configured from branch protection rules. 3. Adding if clause to run the GPU tests only in merge_group. ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence
1 parent 28f9771 commit 2b63217

File tree

3 files changed

+9
-21
lines changed

3 files changed

+9
-21
lines changed

.github/workflows/amd-ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ concurrency:
2626
jobs:
2727
tests:
2828
runs-on: linux-mi300-gpu-1
29-
needs: [checkstyle]
3029
strategy:
3130
matrix:
3231
rocm_version: ['6.3']

.github/workflows/intel-ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ concurrency:
2626
jobs:
2727
tests:
2828
runs-on: linux-max1550-pvc-8
29-
needs: [checkstyle]
3029
if: success()
3130
container:
3231
image: intel/oneapi-basekit:2025.0.1-0-devel-ubuntu24.04

.github/workflows/nvi-ci.yml

Lines changed: 9 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -4,31 +4,23 @@ on:
44
push:
55
branches:
66
- main
7-
paths:
8-
- "src/**"
9-
- "test/**"
107
pull_request:
118
branches:
129
- main
13-
paths:
14-
- "src/**"
15-
- "test/**"
1610
merge_group:
11+
types: [checks_requested]
1712
branches:
1813
- main
19-
paths:
20-
- "src/**"
21-
- "test/**"
2214
workflow_dispatch: # Enables manual trigger
2315

2416
concurrency:
2517
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.event.merge_group.head_ref || github.ref }}
2618
cancel-in-progress: true
2719

2820
jobs:
29-
correctness-tests:
21+
nvi-correctness-tests:
22+
if: github.event_name == 'merge_group'
3023
runs-on: ubuntu-latest
31-
needs: [checkstyle]
3224
env:
3325
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
3426
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
@@ -51,9 +43,9 @@ jobs:
5143
run: |
5244
modal run dev.modal.tests::liger_correctness_tests
5345
54-
convergence-tests:
46+
nvi-convergence-tests:
47+
if: github.event_name == 'merge_group'
5548
runs-on: ubuntu-latest
56-
needs: [checkstyle]
5749
env:
5850
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
5951
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
@@ -76,10 +68,9 @@ jobs:
7668
run: |
7769
modal run dev.modal.tests::liger_convergence_tests
7870
79-
80-
correctness-tests-with-transformers-4-52-0:
71+
nvi-correctness-tests-with-transformers-4-52-0:
72+
if: github.event_name == 'merge_group'
8173
runs-on: ubuntu-latest
82-
needs: [checkstyle]
8374
env:
8475
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
8576
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}
@@ -103,10 +94,9 @@ jobs:
10394
modal run dev.modal.tests::liger_oldest_v4_correctness_tests
10495
10596
106-
107-
convergence-tests-with-transformers-4-52-0:
97+
nvi-convergence-tests-with-transformers-4-52-0:
98+
if: github.event_name == 'merge_group'
10899
runs-on: ubuntu-latest
109-
needs: [checkstyle]
110100
env:
111101
MODAL_TOKEN_ID: ${{ secrets.MODAL_TOKEN_ID }}
112102
MODAL_TOKEN_SECRET: ${{ secrets.MODAL_TOKEN_SECRET }}

0 commit comments

Comments
 (0)