Skip to content

Commit 3c64eaa

Browse files
kolehma8Jari Kolehmainen
andauthored
Relaxing logp relative tolerances for mini-llama4 to fix flaky test. (#1089)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> Relaxing logp relative tolerances for mini-llama4 to fix flaky test. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> Unit testing. <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence Co-authored-by: Jari Kolehmainen <jkolehma@jkolehma-mn7187.linkedin.biz>
1 parent cb8e408 commit 3c64eaa

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/convergence/fp32/test_mini_models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1597,7 +1597,7 @@ def run_mini_model(
15971597
1e-8,
15981598
1e-5,
15991599
5e-3,
1600-
1e-5,
1600+
1e-3,
16011601
5e-3,
16021602
1e-5,
16031603
marks=pytest.mark.skipif(

0 commit comments

Comments
 (0)