Skip to content

Commit 64f5e1d

Browse files
Import glm4_lce_forward locally in function (#695)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> Import glm4_lce_forward locally in function to fix compatibility and tests with older transformers version. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [x] run `make test` to ensure correctness - [x] run `make checkstyle` to ensure code style - [x] run `make test-convergence` to ensure convergence
1 parent a398510 commit 64f5e1d

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

src/liger_kernel/transformers/monkey_patch.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
from liger_kernel.transformers.model.gemma import lce_forward_deprecated as gemma_lce_forward_deprecated
1818
from liger_kernel.transformers.model.gemma2 import lce_forward as gemma2_lce_forward
1919
from liger_kernel.transformers.model.gemma2 import lce_forward_deprecated as gemma2_lce_forward_deprected
20-
from liger_kernel.transformers.model.glm4 import lce_forward as glm4_lce_forward
2120
from liger_kernel.transformers.model.llama import lce_forward as llama_lce_forward
2221
from liger_kernel.transformers.model.llama import lce_forward_deprecated as llama_lce_forward_deprecated
2322
from liger_kernel.transformers.model.llava import lce_forward as llava_lce_forward
@@ -1350,6 +1349,8 @@ def apply_liger_kernel_to_glm4(
13501349
from transformers.models.glm4 import modeling_glm4
13511350
from transformers.models.glm4.modeling_glm4 import Glm4Model
13521351

1352+
from liger_kernel.transformers.model.glm4 import lce_forward as glm4_lce_forward
1353+
13531354
if rope:
13541355
raise NotImplementedError("liger_rotary_pos_emb is not available for Glm4 models.")
13551356
if rms_norm:

0 commit comments

Comments
 (0)