Commit 7656bcb
authored
## Summary
In #1037 I mixed
`benchmark_jsd.py` and `benchmark_distill_jsd_loss.py`.
It is `benchmark_distill_jsd_loss.py` that requires
39GBs of memory:
https://github.com/linkedin/Liger-Kernel/blob/0ea0b8ffcee27c5c94ffa87e480ea95036a0d2da/benchmark/data/all_benchmark_data.csv#L746
69GBs of memory:
https://github.com/linkedin/Liger-Kernel/blob/0ea0b8ffcee27c5c94ffa87e480ea95036a0d2da/benchmark/data/all_benchmark_data.csv#L747
`benchmark_jsd.py` requires just 53GBs:
https://github.com/linkedin/Liger-Kernel/blob/0ea0b8ffcee27c5c94ffa87e480ea95036a0d2da/benchmark/data/all_benchmark_data.csv#L459
## Testing Done
I run both benchmarks on XPU Intel GPU Max 1100 with 48 GBs of memory
- [x] run `make test` to ensure correctness
- [x] run `make checkstyle` to ensure code style
- [x] run `make test-convergence` to ensure convergence
1 parent 0ea0b8f commit 7656bcb
File tree
2 files changed
+13
-6
lines changed- benchmark/scripts
2 files changed
+13
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
12 | 12 | | |
13 | 13 | | |
14 | 14 | | |
| 15 | + | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
| |||
224 | 225 | | |
225 | 226 | | |
226 | 227 | | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
| 231 | + | |
| 232 | + | |
| 233 | + | |
| 234 | + | |
| 235 | + | |
227 | 236 | | |
228 | 237 | | |
229 | 238 | | |
230 | 239 | | |
231 | 240 | | |
232 | | - | |
| 241 | + | |
233 | 242 | | |
234 | 243 | | |
235 | 244 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
125 | 125 | | |
126 | 126 | | |
127 | 127 | | |
128 | | - | |
129 | | - | |
| 128 | + | |
| 129 | + | |
130 | 130 | | |
131 | | - | |
132 | | - | |
133 | 131 | | |
134 | | - | |
| 132 | + | |
135 | 133 | | |
136 | 134 | | |
137 | 135 | | |
| |||
0 commit comments