Skip to content

Commit 7883185

Browse files
Manan17Manan Shah
andauthored
Automate benchmarking - resolving syntax errors (#753)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence --------- Co-authored-by: Manan Shah <[email protected]>
1 parent c794a8f commit 7883185

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

.github/workflows/benchmark.yml

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -33,30 +33,28 @@ jobs:
3333
- name: Checkout code
3434
uses: actions/checkout@v3
3535

36-
# Get the latest commit hash from main branch
36+
# Get the latest commit hash from main branch
3737
- name: Get commit hash
3838
id: get_hash
3939
run: echo "hash=$(git rev-parse --short HEAD)" >> $GITHUB_OUTPUT
4040

41-
4241
- name: Set up Python
4342
uses: actions/setup-python@v3
4443
with:
4544
python-version: '3.10'
4645

47-
# Install dependencies
46+
# Install dependencies
4847
- name: Install dependencies
4948
run: |
5049
python -m pip install --upgrade pip
5150
pip install modal
5251
pip install pandas
5352
54-
# Delete previous benchmark results.
55-
- name: Remove previous benchmark data
53+
# Delete previous benchmark results.
54+
- name: Remove previous benchmark data
5655
run: |
5756
rm -f benchmark/data/all_benchmark_data.csv
58-
59-
57+
6058
- name: Run benchmarks on GPU
6159
run: |
6260
modal run dev.modal.benchmarks
@@ -79,11 +77,9 @@ jobs:
7977
run: |
8078
cd gh-pages
8179
echo "commits.txt file path: ${OUTPUT_DIR}/commits.txt"
82-
8380
# Create file if it doesn't exist
8481
mkdir -p ${OUTPUT_DIR}
8582
touch ${OUTPUT_DIR}/commits.txt
86-
8783
# Append only if not already present
8884
if ! grep -q "${{ steps.get_hash.outputs.hash }}" ${OUTPUT_DIR}/commits.txt; then
8985
echo "${{ steps.get_hash.outputs.hash }}" >> ${OUTPUT_DIR}/commits.txt
@@ -98,5 +94,3 @@ jobs:
9894
git add .
9995
git commit -m "Add benchmark for commit ${{ steps.get_hash.outputs.hash }}" || echo "No changes to commit"
10096
git push origin gh-pages
101-
102-

.github/workflows/docs.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,11 @@ on:
44
branches:
55
- main
66

7-
env:
8-
ENABLE_DEPLOY: false
9-
107
permissions:
118
contents: write
129
jobs:
1310
deploy:
14-
if: env.ENABLE_DEPLOY == 'true'
11+
if: False
1512
runs-on: ubuntu-latest
1613
steps:
1714
- uses: actions/checkout@v4
@@ -30,4 +27,4 @@ jobs:
3027
restore-keys: |
3128
mkdocs-material-
3229
- run: pip install mkdocs-material
33-
- run: mkdocs gh-deploy --force
30+
- run: mkdocs gh-deploy --force

0 commit comments

Comments
 (0)