Skip to content

Commit c1bdc24

Browse files
Manan17Manan Shahvaibhavjindal
authored
Automate benchmarking (#760)
## Summary <!--- This is a required section; please describe the main purpose of this proposed code change. ---> This PR sets the time limit for the modal to run to 90 minutes and also the workflow would be triggered every Friday. <!--- ## Details This is an optional section; is there anything specific that reviewers should be aware of? ---> ## Testing Done <!--- This is a required section; please describe how this change was tested. ---> <!-- Replace BLANK with your device type. For example, A100-80G-PCIe Complete the following tasks before sending your PR, and replace `[ ]` with `[x]` to indicate you have done them. --> - Hardware Type: <BLANK> - [ ] run `make test` to ensure correctness - [ ] run `make checkstyle` to ensure code style - [ ] run `make test-convergence` to ensure convergence --------- Co-authored-by: Manan Shah <[email protected]> Co-authored-by: Vaibhav Jindal <[email protected]>
1 parent 1f640a5 commit c1bdc24

File tree

2 files changed

+5
-8
lines changed

2 files changed

+5
-8
lines changed

.github/workflows/benchmark.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,10 @@
11
name: Benchmarks
22

33
on:
4-
push:
5-
branches:
6-
- main
7-
# paths:
8-
# - "src/**"
9-
# - "test/**"
10-
# - "benchmark/**"
4+
schedule:
5+
# Runs at 00:00 UTC every Friday
6+
- cron: '0 0 * * 5'
7+
workflow_dispatch: # Enables manual trigger
118

129
permissions:
1310
contents: write

dev/modal/benchmarks.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
repo = image.add_local_dir(ROOT_PATH, remote_path=REMOTE_ROOT_PATH)
1515

1616

17-
@app.function(gpu="H100", image=repo, timeout=60 * 45)
17+
@app.function(gpu="H100", image=repo, timeout=60 * 90)
1818
def liger_benchmarks():
1919
import os
2020
import subprocess

0 commit comments

Comments
 (0)