Commit e6fb45a
authored
Fix gemma3 monkey patch tests (#735)
## Summary
With transformers >= 4.52.0, there was some refactoring of gemma3 model
code. Patching should still work for previous transformers version, but
gemma3 tests won't pass for older transformers versions. Not sure we
want to maintain that logic in the tests.
For reference:
- Before (transformers <=4.51.3):
```
Gemma3ForConditionalGeneration
- language_model (Gemma3ForCausalLM)
- model (Gemma3TextModel)
- layers/norm/etc.
```
- After:
```
Gemma3ForConditionalGeneration
- model (Gemma3Model)
- language_model (Gemma3TextModel)
- layers/norm/etc.
- language_model (for backwards-compatibility, points to model.language_model (Gemma3TextModel))
```
Fixing part of #729
## Testing Done
Gemma3 monkey patch tests pass
```
pytest test/transformers/test_monkey_patch.py::test_apply_liger_kernel_to_instance_for_gemma3_conditional_generation
pytest test/transformers/test_monkey_patch.py::test_apply_liger_kernel_to_instance_for_gemma3_text
```
- Hardware Type: <BLANK>
- [ ] run `make test` to ensure correctness
- [ ] run `make checkstyle` to ensure code style
- [ ] run `make test-convergence` to ensure convergence1 parent ea3ac1b commit e6fb45a
File tree
2 files changed
+9
-10
lines changed- src/liger_kernel/transformers
- test/transformers
2 files changed
+9
-10
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
776 | 776 | | |
777 | 777 | | |
778 | 778 | | |
779 | | - | |
| 779 | + | |
780 | 780 | | |
781 | 781 | | |
782 | 782 | | |
| |||
807 | 807 | | |
808 | 808 | | |
809 | 809 | | |
810 | | - | |
| 810 | + | |
811 | 811 | | |
812 | | - | |
| 812 | + | |
813 | 813 | | |
814 | 814 | | |
815 | 815 | | |
| |||
1625 | 1625 | | |
1626 | 1626 | | |
1627 | 1627 | | |
1628 | | - | |
1629 | 1628 | | |
1630 | 1629 | | |
1631 | 1630 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
667 | 667 | | |
668 | 668 | | |
669 | 669 | | |
670 | | - | |
| 670 | + | |
671 | 671 | | |
672 | 672 | | |
673 | 673 | | |
| |||
687 | 687 | | |
688 | 688 | | |
689 | 689 | | |
690 | | - | |
691 | 690 | | |
| 691 | + | |
692 | 692 | | |
693 | 693 | | |
694 | 694 | | |
| |||
704 | 704 | | |
705 | 705 | | |
706 | 706 | | |
707 | | - | |
| 707 | + | |
708 | 708 | | |
709 | 709 | | |
710 | 710 | | |
711 | | - | |
| 711 | + | |
712 | 712 | | |
713 | 713 | | |
714 | 714 | | |
| |||
736 | 736 | | |
737 | 737 | | |
738 | 738 | | |
739 | | - | |
| 739 | + | |
740 | 740 | | |
741 | 741 | | |
742 | | - | |
| 742 | + | |
743 | 743 | | |
744 | 744 | | |
745 | 745 | | |
| |||
0 commit comments