Skip to content

Commit fe2c790

Browse files
lu16jRichard Lu
andauthored
Fix memory leak when saving MentionsEditText state (#133)
Co-authored-by: Richard Lu <rclu@linkedin.com>
1 parent 391b706 commit fe2c790

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

spyglass/src/main/java/com/linkedin/android/spyglass/ui/MentionsEditText.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1379,7 +1379,9 @@ public void setAvoidPrefixOnTap(boolean avoidPrefixOnTap) {
13791379
@Override
13801380
public Parcelable onSaveInstanceState() {
13811381
Parcelable parcelable = super.onSaveInstanceState();
1382-
return new SavedState(parcelable, getMentionsText());
1382+
// Save a copy of MentionsEditable to avoid leaking memory from persisted watchers,
1383+
// as is done in TextView.onSaveInstanceState().
1384+
return new SavedState(parcelable, new MentionsEditable(getMentionsText()));
13831385
}
13841386

13851387
@Override

0 commit comments

Comments
 (0)