Skip to content

Commit 3c8ff7e

Browse files
pratapaditya04Will-Lo
authored andcommitted
[GOBBLIN-2238]Remove unsupported ChaCha20 cipher suites from default SSL configuration (#4153)
* removed chacha cipher suites * added java 8 support matrix
1 parent 2bde25b commit 3c8ff7e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/client/TemporalWorkflowClientFactory.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,16 +66,15 @@ public static ManagedWorkflowServiceStubs createServiceInstance(String connectio
6666
Arrays.asList("TLSv1.2"));
6767
List<String> SSL_CONFIG_DEFAULT_CIPHER_SUITES = Collections.unmodifiableList(Arrays.asList(
6868
// The following list is from https://github.com/netty/netty/blob/4.1/codec-http2/src/main/java/io/netty/handler/codec/http2/Http2SecurityUtil.java#L50
69+
// Supported ciphers for for java 8 https://docs.oracle.com/javase/8/docs/technotes/guides/security/SunProviders.html#SupportedCipherSuites
6970
"TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256",
7071

7172
/* REQUIRED BY HTTP/2 SPEC */
7273
"TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256",
7374
/* REQUIRED BY HTTP/2 SPEC */
7475

7576
"TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384",
76-
"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384",
77-
"TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256",
78-
"TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256"
77+
"TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384"
7978
));
8079

8180
String keyStoreType = config.getString(SSL_KEYSTORE_TYPE);

0 commit comments

Comments
 (0)