Skip to content

Commit 16434eb

Browse files
authored
fix(tracing): Remove opentelemetry vendoring (#4025)
* fix(tracing): Remove opentelemetry vendoring We used to vendor the opentelemetry protobufs because we relied on a version of tonic that `opentelemetry-sdk` didn't support. Now that we've upgraded tonic, we can remove the vendoring and use the official APIs. Signed-off-by: Scott Fleener <[email protected]> * chore(deps): Update opentelemetry deps to 0.30 Signed-off-by: Scott Fleener <[email protected]> * chore(otel): Remove opentelemetry proto generation OpenTelemetry protos are no longer vendored, so we no longer need to generate them. Signed-off-by: Scott Fleener <[email protected]> --------- Signed-off-by: Scott Fleener <[email protected]>
1 parent 7d118d9 commit 16434eb

File tree

22 files changed

+21
-1919
lines changed

22 files changed

+21
-1919
lines changed

Cargo.lock

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -265,9 +265,9 @@ checksum = "9e1b586273c5702936fe7b7d6896644d8be71e6314cfe09d3167c95f712589e8"
265265

266266
[[package]]
267267
name = "base64"
268-
version = "0.22.0"
268+
version = "0.22.1"
269269
source = "registry+https://github.com/rust-lang/crates.io-index"
270-
checksum = "9475866fec1451be56a3c2400fd081ff546538961565ccb5b7142cbd22bc7a51"
270+
checksum = "72b3254f16251a8381aa12e40e3c4d2f0199f8c6508fbecb9d91f575e0fbb8c6"
271271

272272
[[package]]
273273
name = "bindgen"
@@ -2971,13 +2971,17 @@ dependencies = [
29712971

29722972
[[package]]
29732973
name = "opentelemetry-proto"
2974-
version = "0.1.0"
2974+
version = "0.30.0"
2975+
source = "registry+https://github.com/rust-lang/crates.io-index"
2976+
checksum = "2e046fd7660710fe5a05e8748e70d9058dc15c94ba914e7c4faa7c728f0e8ddc"
29752977
dependencies = [
2978+
"base64 0.22.1",
2979+
"hex",
29762980
"opentelemetry",
29772981
"opentelemetry_sdk",
29782982
"prost 0.13.5",
2983+
"serde",
29792984
"tonic",
2980-
"tonic-build",
29812985
]
29822986

29832987
[[package]]
@@ -2992,6 +2996,7 @@ dependencies = [
29922996
"opentelemetry",
29932997
"percent-encoding",
29942998
"rand 0.9.2",
2999+
"serde_json",
29953000
"thiserror 2.0.16",
29963001
]
29973002

@@ -3024,7 +3029,7 @@ version = "3.0.5"
30243029
source = "registry+https://github.com/rust-lang/crates.io-index"
30253030
checksum = "38af38e8470ac9dee3ce1bae1af9c1671fffc44ddfd8bd1d0a3445bf349a8ef3"
30263031
dependencies = [
3027-
"base64 0.22.0",
3032+
"base64 0.22.1",
30283033
"serde",
30293034
]
30303035

@@ -4048,7 +4053,7 @@ checksum = "7e581ba15a835f4d9ea06c55ab1bd4dce26fc53752c69a04aac00703bfb49ba9"
40484053
dependencies = [
40494054
"async-trait",
40504055
"axum",
4051-
"base64 0.22.0",
4056+
"base64 0.22.1",
40524057
"bytes",
40534058
"h2",
40544059
"http",

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ members = [
8686
"linkerd/workers",
8787
"linkerd2-proxy",
8888
"opencensus-proto",
89-
"opentelemetry-proto",
9089
"spiffe-proto",
9190
"tools",
9291
]

linkerd/app/src/trace_collector/otel_collector.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@ use linkerd_app_core::{
55
use linkerd_opentelemetry::{
66
self as opentelemetry, metrics,
77
proto::{
8-
proto::common::v1::{any_value, AnyValue, KeyValue},
9-
transform::common::ResourceAttributesWithSchema,
8+
tonic::common::v1::{any_value, AnyValue, KeyValue},
9+
transform::common::tonic::ResourceAttributesWithSchema,
1010
},
1111
};
1212
use std::{

linkerd/opentelemetry/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ linkerd-metrics = { path = "../metrics" }
1414
linkerd-trace-context = { path = "../trace-context" }
1515
opentelemetry = { version = "0.30", default-features = false, features = ["trace"] }
1616
opentelemetry_sdk = { version = "0.30", default-features = false, features = ["trace"] }
17-
opentelemetry-proto = { path = "../../opentelemetry-proto" }
17+
opentelemetry-proto = { version = "0.30" }
1818
tonic = { workspace = true, default-features = false, features = [
1919
"prost",
2020
"codegen",

linkerd/opentelemetry/src/lib.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,19 @@ use opentelemetry::{
1515
};
1616
pub use opentelemetry_proto as proto;
1717
use opentelemetry_proto::{
18-
proto::{
18+
tonic::{
1919
collector::trace::v1::{
2020
trace_service_client::TraceServiceClient, ExportTraceServiceRequest,
2121
},
2222
trace::v1::ResourceSpans,
2323
},
24-
transform::{common::ResourceAttributesWithSchema, trace::group_spans_by_resource_and_scope},
24+
transform::{
25+
common::tonic::ResourceAttributesWithSchema,
26+
trace::tonic::group_spans_by_resource_and_scope,
27+
},
2528
};
26-
use opentelemetry_sdk::trace::SpanLinks;
27-
pub use opentelemetry_sdk::{self as sdk, trace::SpanData};
29+
use opentelemetry_sdk::trace::{SpanData, SpanLinks};
30+
pub use opentelemetry_sdk::{self as sdk};
2831
use tokio::{sync::mpsc, time};
2932
use tonic::{self as grpc, body::Body as TonicBody, client::GrpcService};
3033
use tracing::{debug, info, trace};

opentelemetry-proto/Cargo.toml

Lines changed: 0 additions & 25 deletions
This file was deleted.

opentelemetry-proto/README.md

Lines changed: 0 additions & 21 deletions
This file was deleted.

opentelemetry-proto/opentelemetry/proto/collector/trace/v1/trace_service.proto

Lines changed: 0 additions & 79 deletions
This file was deleted.

opentelemetry-proto/opentelemetry/proto/common/v1/common.proto

Lines changed: 0 additions & 81 deletions
This file was deleted.

opentelemetry-proto/opentelemetry/proto/resource/v1/resource.proto

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)