Update to Rust v1.54.0 (#1175)

See https://blog.rust-lang.org/2021/07/29/Rust-1.54.0.html

Author: olix0r

.github/actions/package/Dockerfile

@@ -1,4 +1,4 @@
-ARG BASE_IMAGE=rust:1.53.0-buster
+ARG BASE_IMAGE=rust:1.54.0-buster
 FROM $BASE_IMAGE
 WORKDIR /linkerd
 RUN apt-get update && \

.github/workflows/advisory.yml

@@ -24,7 +24,7 @@ jobs:
     timeout-minutes: 40
     runs-on: ubuntu-latest
     container:
-      image: docker://rust:1.53.0-buster
+      image: docker://rust:1.54.0-buster
     permissions:
       contents: read
     strategy:

.github/workflows/coverage.yml

@@ -13,7 +13,7 @@ jobs:
     runs-on: ubuntu-latest
     timeout-minutes: 30
     container:
-      image: docker://rust:1.53.0-buster
+      image: docker://rust:1.54.0-buster
       options: --security-opt seccomp=unconfined
     steps:
     - uses: actions/checkout@5a4ac9002d0be2fb38bd78e4b4dbde5606d7042f

.github/workflows/rust.yml

@@ -24,7 +24,7 @@ jobs:
     timeout-minutes: 5
     runs-on: ubuntu-latest
     container:
-      image: docker://rust:1.53.0-buster
+      image: docker://rust:1.54.0-buster
     permissions:
       contents: read
     steps:
@@ -37,7 +37,7 @@ jobs:
     timeout-minutes: 20
     runs-on: ubuntu-latest
     container:
-      image: docker://rust:1.53.0-buster
+      image: docker://rust:1.54.0-buster
     permissions:
       contents: read
     steps:
@@ -49,7 +49,7 @@ jobs:
     timeout-minutes: 5
     runs-on: ubuntu-latest
     container:
-      image: docker://rust:1.53.0-buster
+      image: docker://rust:1.54.0-buster
     permissions:
       contents: read
     steps:

Dockerfile

@@ -17,7 +17,7 @@
 #     :; docker buildx build . --load
 
 # Please make changes via update-rust-version.sh
-ARG RUST_IMAGE=rust:1.53.0-buster
+ARG RUST_IMAGE=rust:1.54.0-buster
 
 # Use an arbitrary ~recent edge release image to get the proxy
 # identity-initializing and linkerd-await wrappers.
@@ -41,7 +41,7 @@ RUN --mount=type=cache,target=/var/lib/apt/lists \
 WORKDIR /usr/src/linkerd2-proxy
 COPY . .
 RUN --mount=type=cache,target=target \
-  --mount=type=cache,from=rust:1.53.0-buster,source=/usr/local/cargo,target=/usr/local/cargo \
+  --mount=type=cache,from=rust:1.54.0-buster,source=/usr/local/cargo,target=/usr/local/cargo \
   mkdir -p /out && \
   if [ -n "$PROXY_UNOPTIMIZED" ]; then \
   (cd linkerd2-proxy && /usr/bin/time -v cargo build --locked --features="$PROXY_FEATURES") && \

hyper-balance/src/lib.rs

@@ -1,6 +1,5 @@
 #![deny(warnings, rust_2018_idioms)]
 #![forbid(unsafe_code)]
-#![allow(clippy::inconsistent_struct_constructor)]
 
 use hyper::body::HttpBody;
 use pin_project::pin_project;

linkerd/addr/src/lib.rs

@@ -1,6 +1,5 @@
 #![deny(warnings, rust_2018_idioms)]
 #![forbid(unsafe_code)]
-#![allow(clippy::inconsistent_struct_constructor)]
 use linkerd_dns_name::Name;
 use std::{
     fmt,

linkerd/app/core/src/lib.rs

@@ -9,7 +9,6 @@
 
 #![deny(warnings, rust_2018_idioms)]
 #![forbid(unsafe_code)]
-#![allow(clippy::inconsistent_struct_constructor)]
 
 pub use drain;
 pub use linkerd_addr::{self as addr, Addr, NameAddr};

linkerd/app/core/src/retry.rs

@@ -70,18 +70,18 @@ impl RetryPolicy {
         // only if the request contains a `content-length` header and the
         // content length is >= 64 kb.
         let has_body = !req.body().is_end_stream();
-        if has_body && content_length(&req).unwrap_or(usize::MAX) > MAX_BUFFERED_BYTES {
+        if has_body && content_length(req).unwrap_or(usize::MAX) > MAX_BUFFERED_BYTES {
             tracing::trace!(
                 req.has_body = has_body,
-                req.content_length = ?content_length(&req),
+                req.content_length = ?content_length(req),
                 "not retryable",
             );
             return false;
         }
 
         tracing::trace!(
             req.has_body = has_body,
-            req.content_length = ?content_length(&req),
+            req.content_length = ?content_length(req),
             "retryable",
         );
         true
@@ -123,7 +123,7 @@ where
     }
 
     fn clone_request(&self, req: &http::Request<A>) -> Option<http::Request<A>> {
-        let can_retry = self.can_retry(&req);
+        let can_retry = self.can_retry(req);
         debug_assert!(
             can_retry,
             "The retry policy attempted to clone an un-retryable request. This is unexpected."

linkerd/app/gateway/src/lib.rs

@@ -1,6 +1,5 @@
 #![deny(warnings, rust_2018_idioms)]
 #![forbid(unsafe_code)]
-#![allow(clippy::inconsistent_struct_constructor)]
 
 mod gateway;
 #[cfg(test)]