Skip to content

Commit 5366652

Browse files
Propagate correct span ID via W3C context (#2408)
The W3C context propagation uses the wrong span ID right now. That causes all spans emitted by linkerd-proxy to be siblings rather than children of their original parent. This only applies to W3C as far as I can tell, because the B3 propagation uses the span ID correctly. Signed-off-by: Willi Schönborn <[email protected]>
1 parent c30d39f commit 5366652

File tree

1 file changed

+1
-1
lines changed
  • linkerd/trace-context/src/propagation

1 file changed

+1
-1
lines changed

linkerd/trace-context/src/propagation/w3c.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ pub fn increment_http_span_id<B>(request: &mut http::Request<B>, context: &Trace
2525
buf.push('-');
2626
buf.push_str(&hex::encode(context.trace_id.as_ref()));
2727
buf.push('-');
28-
buf.push_str(&hex::encode(context.parent_id.as_ref()));
28+
buf.push_str(&hex::encode(span_id.as_ref()));
2929
buf.push('-');
3030
buf.push_str(&hex::encode(vec![context.flags.0]));
3131
buf

0 commit comments

Comments
 (0)