Skip to content

Commit 757c4e0

Browse files
authored
trace: update tracing-subscriber to 0.2.8; add spans to JSON (#597)
This branch updates the `tracing-subscriber` crate to version 0.2.8, which adds support for serializing the complete span context with the JSON formatter, the way the text log subscriber does. Also, it includes @Pothulapati's change to print thread IDs, which will be useful for debugging the multithreaded runtime. Signed-off-by: Eliza Weisman <[email protected]>
1 parent c7324de commit 757c4e0

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Cargo.lock

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ dependencies = [
3535

3636
[[package]]
3737
name = "ansi_term"
38-
version = "0.11.0"
38+
version = "0.12.1"
3939
source = "registry+https://github.com/rust-lang/crates.io-index"
40-
checksum = "ee49baf6cb617b853aa8d93bf420db2383fab46d314482ca2803b40d5fde979b"
40+
checksum = "d52a9bb7ec0cf484c551830a7ce27bd20d67eac647e1befb56b0be4ee39a55d2"
4141
dependencies = [
4242
"winapi 0.3.8",
4343
]
@@ -2743,9 +2743,9 @@ dependencies = [
27432743

27442744
[[package]]
27452745
name = "tracing-subscriber"
2746-
version = "0.2.7"
2746+
version = "0.2.8"
27472747
source = "registry+https://github.com/rust-lang/crates.io-index"
2748-
checksum = "c72c8cf3ec4ed69fef614d011a5ae4274537a8a8c59133558029bd731eb71659"
2748+
checksum = "cafe899b943f5433c6cab468d75a17ea92948fe9fe60b00f41e13d5e0d4fd054"
27492749
dependencies = [
27502750
"ansi_term",
27512751
"chrono",

linkerd/app/core/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ tracing-log = "0.1"
7373
pin-project = "0.4"
7474

7575
[dependencies.tracing-subscriber]
76-
version = "0.2.7"
76+
version = "0.2.8"
7777
# we don't need `chrono` time formatting
7878
default-features = false
7979
features = ["env-filter", "fmt", "smallvec", "tracing-log", "ansi", "json", "parking_lot"]

linkerd/app/core/src/trace.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub fn with_filter_and_format(
5656

5757
match format.as_ref().to_uppercase().as_ref() {
5858
"JSON" => {
59-
let builder = builder.json().with_filter_reloading();
59+
let builder = builder.json().with_span_list(true).with_filter_reloading();
6060
let handle = LevelHandle::Json(builder.reload_handle());
6161
let dispatch = Dispatch::new(builder.finish());
6262
(dispatch, handle)

0 commit comments

Comments
 (0)