Skip to content

Commit 802d93e

Browse files
authored
fix(http): fix outbound HTTP metrics naming (#2903)
31d7464 introduced a naming regression, so that metrics that 'outbound_http_' became 'outbound_http_http_'. This change fixes this regression.
1 parent 014065d commit 802d93e

File tree

1 file changed

+7
-4
lines changed

1 file changed

+7
-4
lines changed

linkerd/app/outbound/src/metrics.rs

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,13 @@ where
8484

8585
impl PromMetrics {
8686
pub fn register(registry: &mut prom::Registry) -> Self {
87-
Self {
88-
http: crate::http::HttpMetrics::register(registry.sub_registry_with_prefix("http")),
89-
opaq: crate::opaq::OpaqMetrics::register(registry.sub_registry_with_prefix("tcp")),
90-
}
87+
// NOTE: HTTP metrics are scoped internally, since this configures both
88+
// HTTP and gRPC scopes.
89+
let http = crate::http::HttpMetrics::register(registry);
90+
91+
let opaq = crate::opaq::OpaqMetrics::register(registry.sub_registry_with_prefix("tcp"));
92+
93+
Self { http, opaq }
9194
}
9295
}
9396

0 commit comments

Comments
 (0)