refactor(proxy/http): extricate Body middleware types (#3382)

* refactor(proxy/http): move types to `linkerd-http-classify` (#3382)

in this case we already had a crate defining the classify traits, but
the http body and other assorted middleware were defined in
`linkerd-proxy-http`.

this commit moves those types to the `linkerd-http-classify` crate,
which astute readers may notice, is a concrete step towards simplifying
the `linkerd-proxy-http` crate's upgrade process.

one small detail worth calling out: we implement `http_body::Body`
directly, to avoid taking on a `hyper` dependency. otherwise, nothing
has changed in the `channel`, `gate`, and `insert` middleware.

Signed-off-by: katelyn martin <[email protected]>

* refactor(proxy/http): create `linkerd-http-retain` crate (#3382)

this moves the `Retain` middleware from `linkerd-proxy-http` into a new
`linkerd-http-retain` crate.

as previously, reëxports are added to make this a backwards compatible
change.

this moves another http body middleware out of the proxy's core http
crate. great news.

Signed-off-by: katelyn martin <[email protected]>

* refactor(proxy/http): create `linkerd-http-stream-timeouts` crate (#3382)

this commit outlines the stream timeout middleware, pulling it out of
`linkerd-proxy-http` and into a standalone crate.

again, reëxports are added to make this a backwards compatible change.

Signed-off-by: katelyn martin <[email protected]>

* refactor(proxy/http): create  `linkerd-http-override-authority` crate (#3382)

NB: based on #3379 and #3380.

this pull the `override_authority` submodule out of
`linkerd-http-proxy` and into a standalone crate.

Signed-off-by: katelyn martin <[email protected]>

* refactor(proxy/http): move `is_bad_request()` into `upgrade` (#3382)

this is only used in once place, so as a brief chore before we move the
upgrade submodule out into its own crate, we pull `is_bad_request()`
next to its call site.

Signed-off-by: katelyn martin <[email protected]>

* refactor(proxy/http): create `linkerd-http-upgrade` crate (#3382)

this moves the inter-related `upgrade` and `glue` submodules out of the
`linkerd-proxy-http` library and into a new standalone crate.

Signed-off-by: katelyn martin <[email protected]>

---------

Signed-off-by: katelyn martin <[email protected]>

Author: cratelyn

Cargo.lock

@@ -1705,8 +1705,18 @@ dependencies = [
 name = "linkerd-http-classify"
 version = "0.1.0"
 dependencies = [
+ "futures",
  "http",
+ "http-body",
  "linkerd-error",
+ "linkerd-http-box",
+ "linkerd-stack",
+ "linkerd-tracing",
+ "pin-project",
+ "tokio",
+ "tokio-test",
+ "tower-test",
+ "tracing",
 ]
 
 [[package]]
@@ -1753,6 +1763,16 @@ dependencies = [
  "tracing",
 ]
 
+[[package]]
+name = "linkerd-http-override-authority"
+version = "0.1.0"
+dependencies = [
+ "http",
+ "linkerd-stack",
+ "tower",
+ "tracing",
+]
+
 [[package]]
 name = "linkerd-http-prom"
 version = "0.1.0"
@@ -1772,6 +1792,17 @@ dependencies = [
  "tokio",
 ]
 
+[[package]]
+name = "linkerd-http-retain"
+version = "0.1.0"
+dependencies = [
+ "http",
+ "http-body",
+ "linkerd-stack",
+ "pin-project",
+ "tower",
+]
+
 [[package]]
 name = "linkerd-http-retry"
 version = "0.1.0"
@@ -1808,6 +1839,44 @@ dependencies = [
  "url",
 ]
 
+[[package]]
+name = "linkerd-http-stream-timeouts"
+version = "0.1.0"
+dependencies = [
+ "futures",
+ "http",
+ "http-body",
+ "linkerd-error",
+ "linkerd-stack",
+ "parking_lot",
+ "pin-project",
+ "thiserror",
+ "tokio",
+ "tracing",
+]
+
+[[package]]
+name = "linkerd-http-upgrade"
+version = "0.1.0"
+dependencies = [
+ "bytes",
+ "drain",
+ "futures",
+ "http",
+ "http-body",
+ "hyper",
+ "linkerd-duplex",
+ "linkerd-error",
+ "linkerd-http-version",
+ "linkerd-io",
+ "linkerd-stack",
+ "pin-project",
+ "tokio",
+ "tower",
+ "tracing",
+ "try-lock",
+]
+
 [[package]]
 name = "linkerd-http-version"
 version = "0.1.0"
@@ -2178,6 +2247,10 @@ dependencies = [
  "linkerd-http-executor",
  "linkerd-http-h2",
  "linkerd-http-insert",
+ "linkerd-http-override-authority",
+ "linkerd-http-retain",
+ "linkerd-http-stream-timeouts",
+ "linkerd-http-upgrade",
  "linkerd-http-version",
  "linkerd-io",
  "linkerd-proxy-balance",

Cargo.toml

@@ -31,9 +31,13 @@ members = [
     "linkerd/http/h2",
     "linkerd/http/insert",
     "linkerd/http/metrics",
+    "linkerd/http/override-authority",
     "linkerd/http/prom",
+    "linkerd/http/retain",
     "linkerd/http/retry",
     "linkerd/http/route",
+    "linkerd/http/stream-timeouts",
+    "linkerd/http/upgrade",
     "linkerd/http/version",
     "linkerd/identity",
     "linkerd/idle-cache",

linkerd/http/classify/Cargo.toml

@@ -7,6 +7,18 @@ edition = "2021"
 publish = false
 
 [dependencies]
+futures = { version = "0.3", default-features = false }
 http = "0.2"
+http-body = "0.4"
+pin-project = "1"
+tokio = { version = "1", default-features = false }
+tracing = "0.1"
 
 linkerd-error = { path = "../../error" }
+linkerd-http-box = { path = "../../http/box" }
+linkerd-stack = { path = "../../stack" }
+
+[dev-dependencies]
+tokio-test = "0.4"
+tower-test = "0.4"
+linkerd-tracing = { path = "../../tracing", features = ["ansi"] }

linkerd/proxy/http/src/classify/channel.rs renamed to linkerd/http/classify/src/channel.rs

@@ -207,10 +207,10 @@ where
 
 // === impl ResponseBody ===
 
-impl<C, B> hyper::body::HttpBody for ResponseBody<C, B>
+impl<C, B> http_body::Body for ResponseBody<C, B>
 where
     C: ClassifyEos + Unpin,
-    B: hyper::body::HttpBody<Error = Error>,
+    B: http_body::Body<Error = Error>,
 {
     type Data = B::Data;
     type Error = B::Error;

linkerd/proxy/http/src/classify/gate.rs renamed to linkerd/http/classify/src/gate.rs

@@ -1,4 +1,4 @@
-use crate::classify::{BroadcastClassification, ClassifyResponse};
+use crate::{channel::BroadcastClassification, ClassifyResponse};
 use linkerd_stack::{gate, layer, ExtractParam, Gate, NewService};
 use std::marker::PhantomData;
 use tokio::sync::mpsc;

linkerd/proxy/http/src/classify/insert.rs renamed to linkerd/http/classify/src/insert.rs

@@ -3,6 +3,16 @@
 
 use linkerd_error::Error;
 
+pub use self::{
+    channel::{BroadcastClassification, NewBroadcastClassification, Tx},
+    gate::{NewClassifyGate, NewClassifyGateSet},
+    insert::{InsertClassifyResponse, NewInsertClassifyResponse},
+};
+
+pub mod channel;
+pub mod gate;
+mod insert;
+
 /// Determines how a request's response should be classified.
 pub trait Classify {
     type Class: Clone + Send + Sync + 'static;

linkerd/http/classify/src/lib.rs

@@ -0,0 +1,17 @@
+[package]
+name = "linkerd-http-override-authority"
+version = "0.1.0"
+authors = ["Linkerd Developers <[email protected]>"]
+license = "Apache-2.0"
+edition = "2021"
+publish = false
+description = """
+Tower middleware to override request authorities.
+"""
+
+[dependencies]
+http = "0.2"
+tower = { version = "0.4", default-features = false }
+tracing = "0.1"
+
+linkerd-stack = { path = "../../stack" }

linkerd/http/override-authority/Cargo.toml

@@ -1,4 +1,7 @@
-use http::{header::AsHeaderName, uri::Authority};
+use http::{
+    header::AsHeaderName,
+    uri::{self, Authority},
+};
 use linkerd_stack::{layer, NewService, Param};
 use std::{
     fmt,
@@ -23,6 +26,27 @@ pub struct OverrideAuthority<S, H> {
     inner: S,
 }
 
+/// Sets the [`Authority`] of the given URI.
+pub fn set_authority(uri: &mut uri::Uri, auth: Authority) {
+    let mut parts = uri::Parts::from(std::mem::take(uri));
+
+    parts.authority = Some(auth);
+
+    // If this was an origin-form target (path only),
+    // then we can't *only* set the authority, as that's
+    // an illegal target (such as `example.com/docs`).
+    //
+    // But don't set a scheme if this was authority-form (CONNECT),
+    // since that would change its meaning (like `https://example.com`).
+    if parts.path_and_query.is_some() {
+        parts.scheme = Some(http::uri::Scheme::HTTP);
+    }
+
+    let new = http::uri::Uri::from_parts(parts).expect("absolute uri");
+
+    *uri = new;
+}
+
 // === impl NewOverrideAuthority ===
 
 impl<H: Clone, N> NewOverrideAuthority<H, N> {

linkerd/proxy/http/src/override_authority.rs renamed to linkerd/http/override-authority/src/lib.rs

@@ -0,0 +1,20 @@
+[package]
+name = "linkerd-http-retain"
+version = "0.1.0"
+authors = ["Linkerd Developers <[email protected]>"]
+license = "Apache-2.0"
+edition = "2021"
+publish = false
+description = """
+Tower middleware to manage service lifecycles.
+
+This is mostly intended to support cache eviction.
+"""
+
+[dependencies]
+http = "0.2"
+http-body = "0.4"
+pin-project = "1"
+tower = { version = "0.4", default-features = false }
+
+linkerd-stack = { path = "../../stack" }