Skip to content

Commit ca61220

Browse files
authored
chore(app): Disallow warnings in policy router's backend metrics (#3227)
a stray `#![allow(warnings)]` directive seems to have slipped in from an initial prototyping phase. this commit removes this directive from `/linkerd/app/outbound/src/http/logical/policy/route/backend/metrics.rs`, and addresses the newly unearthed warnings, related to unused imports. Signed-off-by: katelyn martin <[email protected]>
1 parent d05b616 commit ca61220

File tree

2 files changed

+2
-10
lines changed

2 files changed

+2
-10
lines changed

linkerd/app/outbound/src/http/logical/policy/route/backend/metrics.rs

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,5 @@
1-
#![allow(warnings)]
2-
31
use crate::{BackendRef, ParentRef, RouteRef};
4-
use futures::Stream;
5-
use linkerd_app_core::{
6-
metrics::prom::{self, encoding::*, EncodeLabelSetMut},
7-
svc,
8-
};
2+
use linkerd_app_core::{metrics::prom, svc};
93
use linkerd_http_prom::{
104
record_response::{self, NewResponseDuration, StreamLabel},
115
NewCountRequests, RequestCount, RequestCountFamilies,

linkerd/app/outbound/src/http/logical/policy/route/backend/metrics/tests.rs

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,8 @@ use super::{
55
LabelGrpcRouteBackendRsp, LabelHttpRouteBackendRsp, RouteBackendMetrics,
66
};
77
use crate::http::{concrete, logical::Concrete};
8-
use linkerd2_proxy_api::outbound::backend;
98
use linkerd_app_core::{
10-
metrics::prom::Counter,
11-
svc::{self, http::BoxBody, Layer, NewService, Service, ServiceExt},
9+
svc::{self, http::BoxBody, Layer, NewService},
1210
transport::{Remote, ServerAddr},
1311
};
1412
use linkerd_proxy_client_policy as policy;

0 commit comments

Comments
 (0)