Skip to content
This repository was archived by the owner on Sep 11, 2020. It is now read-only.

Commit 4a68f5e

Browse files
committed
Merge pull request #137 from Jaza/positionbuttons-p-notnull
re #136: Check that $p is defined in positionButtons
2 parents bdaffee + a6b9419 commit 4a68f5e

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

dist/js/medium-editor-insert-plugin.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -486,9 +486,11 @@ this["MediumInsert"]["Templates"]["src/js/templates/images-toolbar.hbs"] = Handl
486486
left, top;
487487

488488
// Left position is set according to an active paragraph
489-
left = $p.position().left - parseInt($buttons.find('.medium-insert-buttons-addons').css('left'), 10) - parseInt($buttons.find('.medium-insert-buttons-addons a:first').css('margin-left'), 10);
490-
left = left < 0 ? $p.position().left : left;
491-
$buttons.css('left', left);
489+
if ($p.length) {
490+
left = $p.position().left - parseInt($buttons.find('.medium-insert-buttons-addons').css('left'), 10) - parseInt($buttons.find('.medium-insert-buttons-addons a:first').css('margin-left'), 10);
491+
left = left < 0 ? $p.position().left : left;
492+
$buttons.css('left', left);
493+
}
492494

493495
if ($current) {
494496
// Top position is set according to a current active element

src/js/core.js

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -391,9 +391,11 @@
391391
left, top;
392392

393393
// Left position is set according to an active paragraph
394-
left = $p.position().left - parseInt($buttons.find('.medium-insert-buttons-addons').css('left'), 10) - parseInt($buttons.find('.medium-insert-buttons-addons a:first').css('margin-left'), 10);
395-
left = left < 0 ? $p.position().left : left;
396-
$buttons.css('left', left);
394+
if ($p.length) {
395+
left = $p.position().left - parseInt($buttons.find('.medium-insert-buttons-addons').css('left'), 10) - parseInt($buttons.find('.medium-insert-buttons-addons a:first').css('margin-left'), 10);
396+
left = left < 0 ? $p.position().left : left;
397+
$buttons.css('left', left);
398+
}
397399

398400
if ($current) {
399401
// Top position is set according to a current active element

0 commit comments

Comments
 (0)