Add more information about the virtual environment to README

[wdduncan]

The first time going through the README I missed that a venv was being created in environment.sh. Perhaps make this more explicit? Also:

1. Do we want to give an option using pipenv?
2. I typically name my virtual environment .env, so that it is hidden (and add it .gitignore of course). This also give me a directory to put credentials in. The name just seems more intuitive to me. But that is just my opinion.

[wdduncan]

Related to #3

[cmungall]

Happy to go with whatever is more standard! Do you have a link to any best practice guide etc?

…

On Sat, Feb 20, 2021, 09:09 Bill Duncan ***@***.***> wrote: The first time going through the README I missed that a venv was being created in environment.sh. Perhaps make this more explicit? Also: 1. Do we want to give an option using pipenv? 2. I typically name my virtual environment .env, so that it is hidden (and add it .gitignore of course). This also give me a directory to put credentials in. The name just seems more intuitive to me. But that is just my opinion. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#12>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAMMOJN7ULE372PYOJ35QTS77UDFANCNFSM4X6BY73Q> .

[wdduncan]

No ... I'm not aware of a stand path for the virtual environment. I did some searching and didn't find a so-called "standard". I am happy with whichever most folks want.

I think the larger decision may be venv vs pipenv. Conda also has its own virtual environment too.

[TomConlin]

have been using pipenv exclusively for several years,
It works, always seem to be able to recover when it goes sideways,
but I do not recommend it.

If starting fresh I would first consider adopting poetry.

https://python-poetry.org/docs/configuration/

[hsolbrig]

pipenv is an integral part of PyCharm and github actions. Do you see poetry as replacing them? If so, any idea on where it is on the horizon?

[hsolbrig]

An advantage of pipenv, by the way, is that it builds the environments in a local space vs. in the project path itself. We've run into multiple issues with venvs unintentionally showing up on project paths themselves. The disadvantage of pipenv is that it can really fill up the local space -- you periodically need to go in and manually clean up.