Continue on error on message failure 10709#156
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes commit message validation checks non-blocking in GitHub Actions workflows by adding continue-on-error: true to validation steps. The changes update both the workflow templates used by repo-ansible and adjust trigger conditions for different workflow types to better match their purposes.
Key Changes:
- Add
continue-on-error: trueto conventional commits and card number validation steps in the review workflow template - Adjust workflow triggers: remove
editedfrom review workflow (commit checks), addeditedto auto-label workflow (which checks PR descriptions) - Bump version from v0.20.5 to v0.22.0
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| templates/.github/workflows/10-review.yaml.j2 | Adds continue-on-error: true to commit validation steps, making them non-blocking |
| repo.yaml | Version bump to v0.22.0 |
| .github/workflows/auto-label-pull-request.yaml | Adds edited trigger type to re-label PRs when title/description changes |
| .github/workflows/10-review.yaml | Removes edited trigger type (not needed for commit message validation) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist