From 8eb0114e59a7b8c22a385ba247f604c059247d77 Mon Sep 17 00:00:00 2001
From: Marius Ghita <ghita.v.marius@gmail.com>
Date: Sat, 22 Nov 2025 00:51:14 +0200
Subject: [PATCH] fix: continue-on-error at the workflow job level #10709

Using the `continue-on-error` flag at the action level resulted in
jobs showing as passed even if individual steps have failed.
---
 .github/workflows/10-review.yaml              | 3 +--
 templates/.github/workflows/10-review.yaml.j2 | 3 +--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/10-review.yaml b/.github/workflows/10-review.yaml
index 17914bf..b64344f 100644
--- a/.github/workflows/10-review.yaml
+++ b/.github/workflows/10-review.yaml
@@ -11,6 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     # Don't enforce commit conventions checks for Dependabot
     if: github.actor != 'dependabot[bot]'
+    continue-on-error: true
     steps:
       - uses: actions/checkout@v5
 
@@ -18,7 +19,6 @@ jobs:
       - uses: webiny/action-conventional-commits@v1.3.0
         # XXX: normal action versioning syntax (`@v1`) doesn't work with this action,
         # possibly because not published on the GitHub marketplace
-        continue-on-error: true
 
       - name: Check Card# reference
         uses: linkorb/commit-message-checker@v1
@@ -32,5 +32,4 @@ jobs:
           excludeTitle: 'true' # optional: this excludes the title of a pull request
           checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request
           accessToken: ${{ secrets.GITHUB_TOKEN }} # github access token is only required if checkAllCommitMessages is true
-        continue-on-error: true
 
diff --git a/templates/.github/workflows/10-review.yaml.j2 b/templates/.github/workflows/10-review.yaml.j2
index 63e40cb..f3ce32b 100644
--- a/templates/.github/workflows/10-review.yaml.j2
+++ b/templates/.github/workflows/10-review.yaml.j2
@@ -11,6 +11,7 @@ jobs:
     runs-on: ubuntu-latest
     # Don't enforce commit conventions checks for Dependabot
     if: github.actor != 'dependabot[bot]'
+    continue-on-error: true
     steps:
       - uses: actions/checkout@v5
 
@@ -18,7 +19,6 @@ jobs:
       - uses: webiny/action-conventional-commits@v1.3.0
         # XXX: normal action versioning syntax (`@v1`) doesn't work with this action,
         # possibly because not published on the GitHub marketplace
-        continue-on-error: true
 
       - name: Check Card# reference
         uses: linkorb/commit-message-checker@v1
@@ -32,7 +32,6 @@ jobs:
           excludeTitle: 'true' # optional: this excludes the title of a pull request
           checkAllCommitMessages: 'true' # optional: this checks all commits associated with a pull request
           accessToken: ${{ secrets.GITHUB_TOKEN }} # github access token is only required if checkAllCommitMessages is true
-        continue-on-error: true
 
 {% if enable_reviewdog %}
   code-quality: